From: David Miller <davem@davemloft.net>
To: steve@chygwyn.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] decnet: RCU conversion and get rid of dev_base_lock
Date: Mon, 08 Nov 2010 13:43:51 -0800 (PST) [thread overview]
Message-ID: <20101108.134351.229750082.davem@davemloft.net> (raw)
In-Reply-To: <1288360479.9016.35.camel@dolmen>
From: Steven Whitehouse <steve@chygwyn.com>
Date: Fri, 29 Oct 2010 14:54:39 +0100
> Hi,
>
> On Fri, 2010-10-29 at 15:09 +0200, Eric Dumazet wrote:
>> While tracking dev_base_lock users, I found decnet used it in
>> dnet_select_source(), but for a wrong purpose:
>>
>> Writers only hold RTNL, not dev_base_lock, so readers must use RCU if
>> they cannot use RTNL.
>>
>> Adds an rcu_head in struct dn_ifaddr and handle proper RCU management.
>>
>> Adds __rcu annotation in dn_route as well.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> I've not tested this, but I've read through it all and it seems good to
> me.
>
> Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Applied.
prev parent reply other threads:[~2010-11-08 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 13:09 [PATCH] decnet: RCU conversion and get rid of dev_base_lock Eric Dumazet
2010-10-29 13:54 ` Steven Whitehouse
2010-11-08 21:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108.134351.229750082.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve@chygwyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).