From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: alban.crequy@collabora.co.uk, netdev@vger.kernel.org,
davidel@xmailserver.org
Subject: Re: [PATCH 1/2] af_unix: fix unix_dgram_poll() behavior for EPOLLOUT event
Date: Mon, 08 Nov 2010 13:44:38 -0800 (PST) [thread overview]
Message-ID: <20101108.134438.15240252.davem@davemloft.net> (raw)
In-Reply-To: <1288539383.2660.38.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 31 Oct 2010 16:36:23 +0100
> [PATCH 1/2] af_unix: fix unix_dgram_poll() behavior for EPOLLOUT event
>
> Alban Crequy reported a problem with connected dgram af_unix sockets and
> provided a test program. epoll() would miss to send an EPOLLOUT event
> when a thread unqueues a packet from the other peer, making its receive
> queue not full.
>
> This is because unix_dgram_poll() fails to call sock_poll_wait(file,
> &unix_sk(other)->peer_wait, wait);
> if the socket is not writeable at the time epoll_ctl(ADD) is called.
>
> We must call sock_poll_wait(), regardless of 'writable' status, so that
> epoll can be notified later of states changes.
>
> Misc: avoids testing twice (sk->sk_shutdown & RCV_SHUTDOWN)
>
> Reported-by: Alban Crequy <alban.crequy@collabora.co.uk>
> Cc: Davide Libenzi <davidel@xmailserver.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-11-08 21:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 18:18 [PATCH 0/1] RFC: poll/select performance on datagram sockets Alban Crequy
2010-10-29 18:21 ` [PATCH] " Alban Crequy
2010-10-29 19:27 ` [PATCH 0/1] RFC: " Eric Dumazet
2010-10-29 20:08 ` Davide Libenzi
2010-10-29 20:20 ` Eric Dumazet
2010-10-29 20:46 ` Davide Libenzi
2010-10-29 21:05 ` Eric Dumazet
2010-10-29 21:57 ` Davide Libenzi
2010-10-29 22:08 ` Eric Dumazet
2010-10-30 9:53 ` [PATCH] af_unix: optimize unix_dgram_poll() Eric Dumazet
2010-10-30 17:45 ` Davide Libenzi
2010-10-29 20:20 ` [PATCH 0/1] RFC: poll/select performance on datagram sockets Jesper Juhl
2010-10-29 20:40 ` David Miller
2010-10-29 20:45 ` Eric Dumazet
2010-10-30 6:44 ` [PATCH] af_unix: unix_write_space() use keyed wakeups Eric Dumazet
2010-10-30 15:03 ` Davide Libenzi
2010-11-08 21:44 ` David Miller
2010-10-30 21:36 ` Alban Crequy
[not found] ` <1290554876.2158.5.camel@Nokia-N900-51-1>
2010-11-24 0:20 ` Alban Crequy
2010-11-24 0:28 ` Eric Dumazet
2010-10-30 11:34 ` [PATCH 0/1] RFC: poll/select performance on datagram sockets Alban Crequy
2010-10-30 12:53 ` Eric Dumazet
2010-10-30 13:17 ` Eric Dumazet
[not found] ` <20101030224703.065e70f6@chocolatine.cbg.collabora.co.uk>
2010-10-31 15:36 ` [PATCH 1/2] af_unix: fix unix_dgram_poll() behavior for EPOLLOUT event Eric Dumazet
2010-10-31 19:07 ` Davide Libenzi
2010-11-08 21:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108.134438.15240252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alban.crequy@collabora.co.uk \
--cc=davidel@xmailserver.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).