From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: netdev@vger.kernel.org, jitendra.kalsaria@qlogic.com,
ying.lok@qlogic.com
Subject: Re: [net-next PATCH 1/2] qlge: Add firmware info to ethtool get regs.
Date: Mon, 08 Nov 2010 13:49:32 -0800 (PST) [thread overview]
Message-ID: <20101108.134932.116391208.davem@davemloft.net> (raw)
In-Reply-To: <20101108.134302.102548897.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 08 Nov 2010 13:43:02 -0800 (PST)
> From: Ron Mercer <ron.mercer@qlogic.com>
> Date: Wed, 27 Oct 2010 07:58:26 -0700
>
>> By default we add firmware information to ethtool get regs.
>> Optionally firmware info can instead be sent to log.
>>
>> Signed-off-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
>> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
>
> Applied.
Nevermind, reverted, can you please more carefully build test
your changes?
drivers/net/qlge/qlge_mpi.c:90:12: error: static declaration of 'ql_soft_reset_mpi_risc' follows non-static declaration
drivers/net/qlge/qlge.h:2224:5: note: previous declaration of 'ql_soft_reset_mpi_risc' was here
The line that added the extern declaration to qlge.h seems to be completely
unrelated to the rest of the patch, as if it's a mis-commit or something
from another change you were working on.
next prev parent reply other threads:[~2010-11-08 21:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 14:58 [net-next PATCH 1/2] qlge: Add firmware info to ethtool get regs Ron Mercer
2010-10-27 14:58 ` [net-next PATCH 2/2] qlge: Version change to v1.00.00.27 Ron Mercer
2010-11-08 21:43 ` David Miller
2010-11-08 21:43 ` [net-next PATCH 1/2] qlge: Add firmware info to ethtool get regs David Miller
2010-11-08 21:49 ` David Miller [this message]
2010-11-10 19:24 ` Ron Mercer
2010-11-10 19:29 ` Ron Mercer
2010-11-10 20:07 ` David Miller
2010-11-10 19:29 ` [net-next PATCH 2/2] qlge: Version change to v1.00.00.27 Ron Mercer
2010-11-10 20:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108.134932.116391208.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=ying.lok@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).