From: David Miller <davem@davemloft.net>
To: jon.mason@exar.com
Cc: netdev@vger.kernel.org, Sivakumar.Subramani@exar.com,
Sreenivasa.Honnur@exar.com, Ramkrishna.Vepa@exar.com
Subject: Re: [PATCH 01/11] vxge: enable rxhash
Date: Mon, 08 Nov 2010 18:38:06 -0800 (PST) [thread overview]
Message-ID: <20101108.183806.193724928.davem@davemloft.net> (raw)
In-Reply-To: <20101108225340.GA16247@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Mon, 8 Nov 2010 16:53:40 -0600
> On Mon, Nov 08, 2010 at 12:44:52PM -0800, David Miller wrote:
>>
>> This patch set doesn't apply at all to the current tree, please
>> respin them, thanks.
>
> When I sent out the series on Thursday, the tree did not have
> "vxge: make functions local and remove dead code". When that patch
> was originally released (Oct 15), I asked for it to not be included as
> it would break soon-to-be-released patch series. I did not see any
> e-mail afterward, so I assumed this was acceptable to you. We then
> ran the driver though our internal tests to verify its functionality,
> which would need to be re-done if the patches are respun.
>
> I have a reworked version of that patch which can be applied after
> this patch series. Is it acceptable to you to revert the commit,
> apply the series, then apply the modified version of the "local
> functions" patch? I have already sniff tested it on our hardware
> without issues.
Ummm, no. I'm not reverting a correct patch just so that your
original patches apply properly.
Please just respin the patch series on top of the current tree.
next prev parent reply other threads:[~2010-11-09 2:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 22:51 [PATCH 01/11] vxge: enable rxhash Jon Mason
2010-11-04 22:51 ` [PATCH 02/11] vxge: Wait for Rx to become idle before reseting or closing Jon Mason
2010-11-04 22:51 ` [PATCH 03/11] vxge: cleanup debug printing and asserts Jon Mason
2010-11-04 22:51 ` [PATCH 04/11] vxge: serialize access to steering control register Jon Mason
2010-11-04 22:51 ` [PATCH 05/11] vxge: add support for ethtool firmware flashing Jon Mason
2010-11-04 22:51 ` [PATCH 06/11] vxge: add receive hardware timestamping Jon Mason
2010-11-04 22:51 ` [PATCH 07/11] vxge: Handle errors in vxge_hw_vpath_fw_api Jon Mason
2010-11-04 22:51 ` [PATCH 08/11] vxge: Titan1A detection Jon Mason
2010-11-04 22:52 ` [PATCH 09/11] vxge: correct multi-function detection Jon Mason
2010-11-04 22:52 ` [PATCH 10/11] vxge: update Kconfig Jon Mason
2010-11-04 22:52 ` [PATCH 11/11] vxge: update driver version Jon Mason
2010-11-08 20:44 ` [PATCH 01/11] vxge: enable rxhash David Miller
2010-11-08 22:53 ` Jon Mason
2010-11-09 2:38 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-29 2:19 Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108.183806.193724928.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ramkrishna.Vepa@exar.com \
--cc=Sivakumar.Subramani@exar.com \
--cc=Sreenivasa.Honnur@exar.com \
--cc=jon.mason@exar.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).