From: Simon Horman <horms@verge.net.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Julian Anastasov <ja@ssi.bg>,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC v2] ipvs: allow transmit of GRO aggregated skbs
Date: Tue, 9 Nov 2010 06:22:58 +0900 [thread overview]
Message-ID: <20101108212255.GA2308@verge.net.au> (raw)
In-Reply-To: <20101108141955.GA31649@gondor.apana.org.au>
On Mon, Nov 08, 2010 at 10:19:55PM +0800, Herbert Xu wrote:
> On Mon, Nov 08, 2010 at 08:45:42PM +0900, Simon Horman wrote:
> >
> > > Yes, I think we should check for !skb_is_gso(skb)
> > > as it looks as correct check to avoid FRAG_NEEDED after GRO
> > > but lets wait for confirmation from Herbert Xu.
> >
> > Yes, lets try and get a word from Herbert Xu on this.
>
> Yes skb_is_gso(skb) is the best for now. It isn't 100% correct
> as we should still be checking that the gso_size is less than
> the MTU but we need to fix that elsewhere first.
Thanks Herbert.
prev parent reply other threads:[~2010-11-08 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 13:52 [RFC] ipvs: allow transmit of GRO aggregated skbs Simon Horman
2010-11-05 23:54 ` [RFC v2] " Simon Horman
2010-11-06 14:18 ` Julian Anastasov
2010-11-06 14:28 ` Simon Horman
2010-11-08 7:31 ` Simon Horman
2010-11-08 9:36 ` Julian Anastasov
2010-11-08 11:45 ` Simon Horman
2010-11-08 14:19 ` Herbert Xu
2010-11-08 21:22 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108212255.GA2308@verge.net.au \
--to=horms@verge.net.au \
--cc=herbert@gondor.apana.org.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).