From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: markus@trippelsdorf.de, paulmck@linux.vnet.ibm.com,
miles.lane@gmail.com, ilpo.jarvinen@helsinki.fi,
linux-kernel@vger.kernel.org, lenb@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] inet: fix ip_mc_drop_socket()
Date: Tue, 09 Nov 2010 08:26:56 -0800 (PST) [thread overview]
Message-ID: <20101109.082656.193719925.davem@davemloft.net> (raw)
In-Reply-To: <1289250954.2790.11.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 08 Nov 2010 22:15:54 +0100
> Hmm, I believe I found the bug.
>
> Thanks guys !
>
> [PATCH] inet: fix ip_mc_drop_socket()
>
> commit 8723e1b4ad9be4444 (inet: RCU changes in inetdev_by_index())
> forgot one call site in ip_mc_drop_socket()
>
> We should not decrease idev refcount after inetdev_by_index() call,
> since refcount is not increased anymore.
>
> Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> Reported-by: Miles Lane <miles.lane@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks a lot!
prev parent reply other threads:[~2010-11-09 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTinVyf4CpxdzEWUn7zTyOrAMKY3H9Dct-HfopiSD@mail.gmail.com>
2010-11-08 20:06 ` 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() Paul E. McKenney
2010-11-08 20:29 ` Eric Dumazet
2010-11-08 20:42 ` Markus Trippelsdorf
2010-11-08 20:46 ` Eric Dumazet
2010-11-08 20:50 ` Miles Lane
2010-11-08 20:55 ` Markus Trippelsdorf
2010-11-08 21:15 ` [PATCH] inet: fix ip_mc_drop_socket() Eric Dumazet
2010-11-09 4:20 ` Miles Lane
2010-11-09 16:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109.082656.193719925.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=miles.lane@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).