* Re: 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() [not found] <AANLkTinVyf4CpxdzEWUn7zTyOrAMKY3H9Dct-HfopiSD@mail.gmail.com> @ 2010-11-08 20:06 ` Paul E. McKenney 2010-11-08 20:29 ` Eric Dumazet 0 siblings, 1 reply; 9+ messages in thread From: Paul E. McKenney @ 2010-11-08 20:06 UTC (permalink / raw) To: Miles Lane, ilpo.jarvinen; +Cc: LKML, Len Brown, netdev On Mon, Nov 08, 2010 at 02:56:06PM -0500, Miles Lane wrote: > WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() > Hardware name: UL50VT > Modules linked in: ipv6 snd_hda_codec_hdmi snd_hda_codec_realtek > snd_hda_intel snd_hda_codec snd_pcm_oss snd_hwdep snd_mixer_oss > snd_seq_dummy snd_pcm snd_seq_oss snd_seq_midi iwlagn snd_rawmidi > snd_seq_midi_event snd_seq iwlcore uvcvideo snd_timer mac80211 > snd_seq_device videodev v4l1_compat v4l2_compat_ioctl32 i915 snd > rtc_cmos rtc_core psmouse cfg80211 soundcore drm_kms_helper > snd_page_alloc rtc_lib asus_laptop video battery ac sparse_keymap wmi > button rfkill processor power_supply led_class usb_storage sg sr_mod > sd_mod cdrom atl1c ehci_hcd uhci_hcd thermal thermal_sys hwmon > Pid: 0, comm: kworker/0:0 Not tainted 2.6.37-rc1-git5 #10 > Call Trace: > <IRQ> [<ffffffff8103767e>] warn_slowpath_common+0x80/0x98 > [<ffffffff810376ab>] warn_slowpath_null+0x15/0x17 > [<ffffffff8130d549>] in_dev_finish_destroy+0x3d/0x6e > [<ffffffff8130d58e>] in_dev_put+0x14/0x16 > [<ffffffff8130d5ab>] inet_rcu_free_ifa+0x1b/0x27 > [<ffffffff810834a8>] __rcu_process_callbacks+0x1a4/0x2bc > [<ffffffff8108363b>] rcu_process_callbacks+0x7b/0x82 > [<ffffffff8103cb9c>] __do_softirq+0xb8/0x15a > [<ffffffff8100394c>] call_softirq+0x1c/0x28 > [<ffffffff81005637>] do_softirq+0x38/0x81 > [<ffffffff8103cce9>] irq_exit+0x45/0x94 > [<ffffffff8101ac1f>] smp_apic_timer_interrupt+0x78/0x86 > [<ffffffff81003413>] apic_timer_interrupt+0x13/0x20 > <EOI> [<ffffffff8134aff6>] ? _raw_spin_unlock_irqrestore+0x3c/0x69 > [<ffffffff81059cb3>] clockevents_notify+0x11e/0x12d > [<ffffffffa008e561>] ? acpi_idle_enter_bm+0x236/0x271 [processor] > [<ffffffffa008dfce>] lapic_timer_state_broadcast+0x41/0x43 [processor] > [<ffffffffa008e588>] acpi_idle_enter_bm+0x25d/0x271 [processor] > [<ffffffff8129db30>] cpuidle_idle_call+0x9e/0xda > [<ffffffff810012ea>] cpu_idle+0xce/0x10c > [<ffffffff81343ce8>] start_secondary+0x1fc/0x205 > ---[ end trace 1d49bc8ff0266634 ]--- > Freeing alive in_device ffff88013fe536d0 Ilpo, thoughts? Thanx, Paul ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() 2010-11-08 20:06 ` 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() Paul E. McKenney @ 2010-11-08 20:29 ` Eric Dumazet 2010-11-08 20:42 ` Markus Trippelsdorf 0 siblings, 1 reply; 9+ messages in thread From: Eric Dumazet @ 2010-11-08 20:29 UTC (permalink / raw) To: paulmck; +Cc: Miles Lane, ilpo.jarvinen, LKML, Len Brown, netdev Le lundi 08 novembre 2010 à 12:06 -0800, Paul E. McKenney a écrit : > On Mon, Nov 08, 2010 at 02:56:06PM -0500, Miles Lane wrote: > > WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() > > Hardware name: UL50VT > > Modules linked in: ipv6 snd_hda_codec_hdmi snd_hda_codec_realtek > > snd_hda_intel snd_hda_codec snd_pcm_oss snd_hwdep snd_mixer_oss > > snd_seq_dummy snd_pcm snd_seq_oss snd_seq_midi iwlagn snd_rawmidi > > snd_seq_midi_event snd_seq iwlcore uvcvideo snd_timer mac80211 > > snd_seq_device videodev v4l1_compat v4l2_compat_ioctl32 i915 snd > > rtc_cmos rtc_core psmouse cfg80211 soundcore drm_kms_helper > > snd_page_alloc rtc_lib asus_laptop video battery ac sparse_keymap wmi > > button rfkill processor power_supply led_class usb_storage sg sr_mod > > sd_mod cdrom atl1c ehci_hcd uhci_hcd thermal thermal_sys hwmon > > Pid: 0, comm: kworker/0:0 Not tainted 2.6.37-rc1-git5 #10 > > Call Trace: > > <IRQ> [<ffffffff8103767e>] warn_slowpath_common+0x80/0x98 > > [<ffffffff810376ab>] warn_slowpath_null+0x15/0x17 > > [<ffffffff8130d549>] in_dev_finish_destroy+0x3d/0x6e > > [<ffffffff8130d58e>] in_dev_put+0x14/0x16 > > [<ffffffff8130d5ab>] inet_rcu_free_ifa+0x1b/0x27 > > [<ffffffff810834a8>] __rcu_process_callbacks+0x1a4/0x2bc > > [<ffffffff8108363b>] rcu_process_callbacks+0x7b/0x82 > > [<ffffffff8103cb9c>] __do_softirq+0xb8/0x15a > > [<ffffffff8100394c>] call_softirq+0x1c/0x28 > > [<ffffffff81005637>] do_softirq+0x38/0x81 > > [<ffffffff8103cce9>] irq_exit+0x45/0x94 > > [<ffffffff8101ac1f>] smp_apic_timer_interrupt+0x78/0x86 > > [<ffffffff81003413>] apic_timer_interrupt+0x13/0x20 > > <EOI> [<ffffffff8134aff6>] ? _raw_spin_unlock_irqrestore+0x3c/0x69 > > [<ffffffff81059cb3>] clockevents_notify+0x11e/0x12d > > [<ffffffffa008e561>] ? acpi_idle_enter_bm+0x236/0x271 [processor] > > [<ffffffffa008dfce>] lapic_timer_state_broadcast+0x41/0x43 [processor] > > [<ffffffffa008e588>] acpi_idle_enter_bm+0x25d/0x271 [processor] > > [<ffffffff8129db30>] cpuidle_idle_call+0x9e/0xda > > [<ffffffff810012ea>] cpu_idle+0xce/0x10c > > [<ffffffff81343ce8>] start_secondary+0x1fc/0x205 > > ---[ end trace 1d49bc8ff0266634 ]--- > > Freeing alive in_device ffff88013fe536d0 > > Ilpo, thoughts? > Hmm... WARN_ON(idev->mc_list); Might be a problem with refcounts somewhere... Miles, is it reproductible ? Thanks ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() 2010-11-08 20:29 ` Eric Dumazet @ 2010-11-08 20:42 ` Markus Trippelsdorf 2010-11-08 20:46 ` Eric Dumazet 0 siblings, 1 reply; 9+ messages in thread From: Markus Trippelsdorf @ 2010-11-08 20:42 UTC (permalink / raw) To: Eric Dumazet; +Cc: paulmck, Miles Lane, ilpo.jarvinen, LKML, Len Brown, netdev On Mon, Nov 08, 2010 at 09:29:26PM +0100, Eric Dumazet wrote: > Le lundi 08 novembre 2010 à 12:06 -0800, Paul E. McKenney a écrit : > > On Mon, Nov 08, 2010 at 02:56:06PM -0500, Miles Lane wrote: > > > WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() > > > Hardware name: UL50VT > > > Modules linked in: ipv6 snd_hda_codec_hdmi snd_hda_codec_realtek > > > snd_hda_intel snd_hda_codec snd_pcm_oss snd_hwdep snd_mixer_oss > > > snd_seq_dummy snd_pcm snd_seq_oss snd_seq_midi iwlagn snd_rawmidi > > > snd_seq_midi_event snd_seq iwlcore uvcvideo snd_timer mac80211 > > > snd_seq_device videodev v4l1_compat v4l2_compat_ioctl32 i915 snd > > > rtc_cmos rtc_core psmouse cfg80211 soundcore drm_kms_helper > > > snd_page_alloc rtc_lib asus_laptop video battery ac sparse_keymap wmi > > > button rfkill processor power_supply led_class usb_storage sg sr_mod > > > sd_mod cdrom atl1c ehci_hcd uhci_hcd thermal thermal_sys hwmon > > > Pid: 0, comm: kworker/0:0 Not tainted 2.6.37-rc1-git5 #10 > > > Call Trace: > > > <IRQ> [<ffffffff8103767e>] warn_slowpath_common+0x80/0x98 > > > [<ffffffff810376ab>] warn_slowpath_null+0x15/0x17 > > > [<ffffffff8130d549>] in_dev_finish_destroy+0x3d/0x6e > > > [<ffffffff8130d58e>] in_dev_put+0x14/0x16 > > > [<ffffffff8130d5ab>] inet_rcu_free_ifa+0x1b/0x27 > > > [<ffffffff810834a8>] __rcu_process_callbacks+0x1a4/0x2bc > > > [<ffffffff8108363b>] rcu_process_callbacks+0x7b/0x82 > > > [<ffffffff8103cb9c>] __do_softirq+0xb8/0x15a > > > [<ffffffff8100394c>] call_softirq+0x1c/0x28 > > > [<ffffffff81005637>] do_softirq+0x38/0x81 > > > [<ffffffff8103cce9>] irq_exit+0x45/0x94 > > > [<ffffffff8101ac1f>] smp_apic_timer_interrupt+0x78/0x86 > > > [<ffffffff81003413>] apic_timer_interrupt+0x13/0x20 > > > <EOI> [<ffffffff8134aff6>] ? _raw_spin_unlock_irqrestore+0x3c/0x69 > > > [<ffffffff81059cb3>] clockevents_notify+0x11e/0x12d > > > [<ffffffffa008e561>] ? acpi_idle_enter_bm+0x236/0x271 [processor] > > > [<ffffffffa008dfce>] lapic_timer_state_broadcast+0x41/0x43 [processor] > > > [<ffffffffa008e588>] acpi_idle_enter_bm+0x25d/0x271 [processor] > > > [<ffffffff8129db30>] cpuidle_idle_call+0x9e/0xda > > > [<ffffffff810012ea>] cpu_idle+0xce/0x10c > > > [<ffffffff81343ce8>] start_secondary+0x1fc/0x205 > > > ---[ end trace 1d49bc8ff0266634 ]--- > > > Freeing alive in_device ffff88013fe536d0 > > > > Ilpo, thoughts? > > > > Hmm... > > WARN_ON(idev->mc_list); > > Might be a problem with refcounts somewhere... I have similar warnings in my logs, although its at net/ipv4/devinet.c:136 in my case. Happened altogether three times in the last few days and they all look the same: Nov 5 17:31:35 arch kernel: WARNING: at net/ipv4/devinet.c:136 in_dev_finish_destroy+0x5c/0x90() Nov 5 17:31:35 arch kernel: Hardware name: System Product Name Nov 5 17:31:35 arch kernel: Pid: 0, comm: kworker/0:1 Not tainted 2.6.37-rc1-00027-gff8b16d-dirty #4 Nov 5 17:31:35 arch kernel: Call Trace: Nov 5 17:31:35 arch kernel: <IRQ> [<ffffffff8105c9f6>] ? warn_slowpath_common+0x76/0xc0 Nov 5 17:31:35 arch kernel: [<ffffffff8141889c>] ? in_dev_finish_destroy+0x5c/0x90 Nov 5 17:31:35 arch kernel: [<ffffffff813c49e8>] ? dst_destroy+0x68/0x120 Nov 5 17:31:35 arch kernel: [<ffffffff813e888f>] ? dst_rcu_free+0x1f/0x30 Nov 5 17:31:35 arch kernel: [<ffffffff81090e0c>] ? __rcu_process_callbacks+0xfc/0x2f0 Nov 5 17:31:35 arch kernel: [<ffffffff8109103f>] ? rcu_process_callbacks+0x3f/0x70 Nov 5 17:31:35 arch kernel: [<ffffffff810621bc>] ? __do_softirq+0x9c/0x120 Nov 5 17:31:35 arch kernel: [<ffffffff81030fc9>] ? timer_interrupt+0x19/0x30 Nov 5 17:31:35 arch kernel: [<ffffffff8102ea4c>] ? call_softirq+0x1c/0x30 Nov 5 17:31:35 arch kernel: [<ffffffff8103080d>] ? do_softirq+0x4d/0x80 Nov 5 17:31:35 arch kernel: [<ffffffff8106232d>] ? irq_exit+0x8d/0x90 Nov 5 17:31:35 arch kernel: [<ffffffff810306c7>] ? do_IRQ+0x67/0xe0 Nov 5 17:31:35 arch kernel: [<ffffffff8144a153>] ? ret_from_intr+0x0/0xa Nov 5 17:31:35 arch kernel: <EOI> [<ffffffff81035ba0>] ? default_idle+0x20/0x40 Nov 5 17:31:35 arch kernel: [<ffffffff81035c12>] ? c1e_idle+0x52/0xf0 Nov 5 17:31:35 arch kernel: [<ffffffff8102c12c>] ? cpu_idle+0x4c/0xa0 Nov 5 17:31:35 arch kernel: ---[ end trace 143683935de8f41f ]--- Nov 5 17:31:35 arch kernel: Freeing alive in_device ffff88011ffba600 -- Markus ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() 2010-11-08 20:42 ` Markus Trippelsdorf @ 2010-11-08 20:46 ` Eric Dumazet 2010-11-08 20:50 ` Miles Lane 2010-11-08 20:55 ` Markus Trippelsdorf 0 siblings, 2 replies; 9+ messages in thread From: Eric Dumazet @ 2010-11-08 20:46 UTC (permalink / raw) To: Markus Trippelsdorf Cc: paulmck, Miles Lane, ilpo.jarvinen, LKML, Len Brown, netdev Le lundi 08 novembre 2010 à 21:42 +0100, Markus Trippelsdorf a écrit : > On Mon, Nov 08, 2010 at 09:29:26PM +0100, Eric Dumazet wrote: > > Le lundi 08 novembre 2010 à 12:06 -0800, Paul E. McKenney a écrit : > > > On Mon, Nov 08, 2010 at 02:56:06PM -0500, Miles Lane wrote: > > > > WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() > > > > Hardware name: UL50VT > > > > Modules linked in: ipv6 snd_hda_codec_hdmi snd_hda_codec_realtek > > > > snd_hda_intel snd_hda_codec snd_pcm_oss snd_hwdep snd_mixer_oss > > > > snd_seq_dummy snd_pcm snd_seq_oss snd_seq_midi iwlagn snd_rawmidi > > > > snd_seq_midi_event snd_seq iwlcore uvcvideo snd_timer mac80211 > > > > snd_seq_device videodev v4l1_compat v4l2_compat_ioctl32 i915 snd > > > > rtc_cmos rtc_core psmouse cfg80211 soundcore drm_kms_helper > > > > snd_page_alloc rtc_lib asus_laptop video battery ac sparse_keymap wmi > > > > button rfkill processor power_supply led_class usb_storage sg sr_mod > > > > sd_mod cdrom atl1c ehci_hcd uhci_hcd thermal thermal_sys hwmon > > > > Pid: 0, comm: kworker/0:0 Not tainted 2.6.37-rc1-git5 #10 > > > > Call Trace: > > > > <IRQ> [<ffffffff8103767e>] warn_slowpath_common+0x80/0x98 > > > > [<ffffffff810376ab>] warn_slowpath_null+0x15/0x17 > > > > [<ffffffff8130d549>] in_dev_finish_destroy+0x3d/0x6e > > > > [<ffffffff8130d58e>] in_dev_put+0x14/0x16 > > > > [<ffffffff8130d5ab>] inet_rcu_free_ifa+0x1b/0x27 > > > > [<ffffffff810834a8>] __rcu_process_callbacks+0x1a4/0x2bc > > > > [<ffffffff8108363b>] rcu_process_callbacks+0x7b/0x82 > > > > [<ffffffff8103cb9c>] __do_softirq+0xb8/0x15a > > > > [<ffffffff8100394c>] call_softirq+0x1c/0x28 > > > > [<ffffffff81005637>] do_softirq+0x38/0x81 > > > > [<ffffffff8103cce9>] irq_exit+0x45/0x94 > > > > [<ffffffff8101ac1f>] smp_apic_timer_interrupt+0x78/0x86 > > > > [<ffffffff81003413>] apic_timer_interrupt+0x13/0x20 > > > > <EOI> [<ffffffff8134aff6>] ? _raw_spin_unlock_irqrestore+0x3c/0x69 > > > > [<ffffffff81059cb3>] clockevents_notify+0x11e/0x12d > > > > [<ffffffffa008e561>] ? acpi_idle_enter_bm+0x236/0x271 [processor] > > > > [<ffffffffa008dfce>] lapic_timer_state_broadcast+0x41/0x43 [processor] > > > > [<ffffffffa008e588>] acpi_idle_enter_bm+0x25d/0x271 [processor] > > > > [<ffffffff8129db30>] cpuidle_idle_call+0x9e/0xda > > > > [<ffffffff810012ea>] cpu_idle+0xce/0x10c > > > > [<ffffffff81343ce8>] start_secondary+0x1fc/0x205 > > > > ---[ end trace 1d49bc8ff0266634 ]--- > > > > Freeing alive in_device ffff88013fe536d0 > > > > > > Ilpo, thoughts? > > > > > > > Hmm... > > > > WARN_ON(idev->mc_list); > > > > Might be a problem with refcounts somewhere... > > I have similar warnings in my logs, although its at > net/ipv4/devinet.c:136 in my case. Happened altogether three times in > the last few days and they all look the same: > > Nov 5 17:31:35 arch kernel: WARNING: at net/ipv4/devinet.c:136 in_dev_finish_destroy+0x5c/0x90() > Nov 5 17:31:35 arch kernel: Hardware name: System Product Name > Nov 5 17:31:35 arch kernel: Pid: 0, comm: kworker/0:1 Not tainted 2.6.37-rc1-00027-gff8b16d-dirty #4 > Nov 5 17:31:35 arch kernel: Call Trace: > Nov 5 17:31:35 arch kernel: <IRQ> [<ffffffff8105c9f6>] ? warn_slowpath_common+0x76/0xc0 > Nov 5 17:31:35 arch kernel: [<ffffffff8141889c>] ? in_dev_finish_destroy+0x5c/0x90 > Nov 5 17:31:35 arch kernel: [<ffffffff813c49e8>] ? dst_destroy+0x68/0x120 > Nov 5 17:31:35 arch kernel: [<ffffffff813e888f>] ? dst_rcu_free+0x1f/0x30 > Nov 5 17:31:35 arch kernel: [<ffffffff81090e0c>] ? __rcu_process_callbacks+0xfc/0x2f0 > Nov 5 17:31:35 arch kernel: [<ffffffff8109103f>] ? rcu_process_callbacks+0x3f/0x70 > Nov 5 17:31:35 arch kernel: [<ffffffff810621bc>] ? __do_softirq+0x9c/0x120 > Nov 5 17:31:35 arch kernel: [<ffffffff81030fc9>] ? timer_interrupt+0x19/0x30 > Nov 5 17:31:35 arch kernel: [<ffffffff8102ea4c>] ? call_softirq+0x1c/0x30 > Nov 5 17:31:35 arch kernel: [<ffffffff8103080d>] ? do_softirq+0x4d/0x80 > Nov 5 17:31:35 arch kernel: [<ffffffff8106232d>] ? irq_exit+0x8d/0x90 > Nov 5 17:31:35 arch kernel: [<ffffffff810306c7>] ? do_IRQ+0x67/0xe0 > Nov 5 17:31:35 arch kernel: [<ffffffff8144a153>] ? ret_from_intr+0x0/0xa > Nov 5 17:31:35 arch kernel: <EOI> [<ffffffff81035ba0>] ? default_idle+0x20/0x40 > Nov 5 17:31:35 arch kernel: [<ffffffff81035c12>] ? c1e_idle+0x52/0xf0 > Nov 5 17:31:35 arch kernel: [<ffffffff8102c12c>] ? cpu_idle+0x4c/0xa0 > Nov 5 17:31:35 arch kernel: ---[ end trace 143683935de8f41f ]--- > Nov 5 17:31:35 arch kernel: Freeing alive in_device ffff88011ffba600 > Hmm.... Is commit 1f1b9c9990205759aae31b7734b0ede41a867f32 present in your kernel ? (fib: fib_result_assign() should not change fib refcounts) Could you provide some information ? ifconfig -a ip ro Thanks ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() 2010-11-08 20:46 ` Eric Dumazet @ 2010-11-08 20:50 ` Miles Lane 2010-11-08 20:55 ` Markus Trippelsdorf 1 sibling, 0 replies; 9+ messages in thread From: Miles Lane @ 2010-11-08 20:50 UTC (permalink / raw) To: Eric Dumazet Cc: Markus Trippelsdorf, paulmck, ilpo.jarvinen, LKML, Len Brown, netdev # ifconfig -a eth0 Link encap:Ethernet HWaddr e0:cb:4e:0a:ba:16 UP BROADCAST MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) Interrupt:48 lo Link encap:Local Loopback inet addr:127.0.0.1 Mask:255.0.0.0 inet6 addr: ::1/128 Scope:Host UP LOOPBACK RUNNING MTU:16436 Metric:1 RX packets:12 errors:0 dropped:0 overruns:0 frame:0 TX packets:12 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:720 (720.0 B) TX bytes:720 (720.0 B) wlan0 Link encap:Ethernet HWaddr 00:1e:64:06:05:96 inet addr:192.168.1.104 Bcast:192.168.1.255 Mask:255.255.255.0 inet6 addr: fe80::21e:64ff:fe06:596/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:86889 errors:0 dropped:1 overruns:0 frame:0 TX packets:53180 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:88241580 (88.2 MB) TX bytes:10132172 (10.1 MB) # ip ro 192.168.1.0/24 dev wlan0 proto kernel scope link src 192.168.1.104 metric 2 169.254.0.0/16 dev wlan0 scope link metric 1000 default via 192.168.1.1 dev wlan0 proto static On Mon, Nov 8, 2010 at 3:46 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Le lundi 08 novembre 2010 à 21:42 +0100, Markus Trippelsdorf a écrit : >> On Mon, Nov 08, 2010 at 09:29:26PM +0100, Eric Dumazet wrote: >> > Le lundi 08 novembre 2010 à 12:06 -0800, Paul E. McKenney a écrit : >> > > On Mon, Nov 08, 2010 at 02:56:06PM -0500, Miles Lane wrote: >> > > > WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() >> > > > Hardware name: UL50VT >> > > > Modules linked in: ipv6 snd_hda_codec_hdmi snd_hda_codec_realtek >> > > > snd_hda_intel snd_hda_codec snd_pcm_oss snd_hwdep snd_mixer_oss >> > > > snd_seq_dummy snd_pcm snd_seq_oss snd_seq_midi iwlagn snd_rawmidi >> > > > snd_seq_midi_event snd_seq iwlcore uvcvideo snd_timer mac80211 >> > > > snd_seq_device videodev v4l1_compat v4l2_compat_ioctl32 i915 snd >> > > > rtc_cmos rtc_core psmouse cfg80211 soundcore drm_kms_helper >> > > > snd_page_alloc rtc_lib asus_laptop video battery ac sparse_keymap wmi >> > > > button rfkill processor power_supply led_class usb_storage sg sr_mod >> > > > sd_mod cdrom atl1c ehci_hcd uhci_hcd thermal thermal_sys hwmon >> > > > Pid: 0, comm: kworker/0:0 Not tainted 2.6.37-rc1-git5 #10 >> > > > Call Trace: >> > > > <IRQ> [<ffffffff8103767e>] warn_slowpath_common+0x80/0x98 >> > > > [<ffffffff810376ab>] warn_slowpath_null+0x15/0x17 >> > > > [<ffffffff8130d549>] in_dev_finish_destroy+0x3d/0x6e >> > > > [<ffffffff8130d58e>] in_dev_put+0x14/0x16 >> > > > [<ffffffff8130d5ab>] inet_rcu_free_ifa+0x1b/0x27 >> > > > [<ffffffff810834a8>] __rcu_process_callbacks+0x1a4/0x2bc >> > > > [<ffffffff8108363b>] rcu_process_callbacks+0x7b/0x82 >> > > > [<ffffffff8103cb9c>] __do_softirq+0xb8/0x15a >> > > > [<ffffffff8100394c>] call_softirq+0x1c/0x28 >> > > > [<ffffffff81005637>] do_softirq+0x38/0x81 >> > > > [<ffffffff8103cce9>] irq_exit+0x45/0x94 >> > > > [<ffffffff8101ac1f>] smp_apic_timer_interrupt+0x78/0x86 >> > > > [<ffffffff81003413>] apic_timer_interrupt+0x13/0x20 >> > > > <EOI> [<ffffffff8134aff6>] ? _raw_spin_unlock_irqrestore+0x3c/0x69 >> > > > [<ffffffff81059cb3>] clockevents_notify+0x11e/0x12d >> > > > [<ffffffffa008e561>] ? acpi_idle_enter_bm+0x236/0x271 [processor] >> > > > [<ffffffffa008dfce>] lapic_timer_state_broadcast+0x41/0x43 [processor] >> > > > [<ffffffffa008e588>] acpi_idle_enter_bm+0x25d/0x271 [processor] >> > > > [<ffffffff8129db30>] cpuidle_idle_call+0x9e/0xda >> > > > [<ffffffff810012ea>] cpu_idle+0xce/0x10c >> > > > [<ffffffff81343ce8>] start_secondary+0x1fc/0x205 >> > > > ---[ end trace 1d49bc8ff0266634 ]--- >> > > > Freeing alive in_device ffff88013fe536d0 >> > > >> > > Ilpo, thoughts? >> > > >> > >> > Hmm... >> > >> > WARN_ON(idev->mc_list); >> > >> > Might be a problem with refcounts somewhere... >> >> I have similar warnings in my logs, although its at >> net/ipv4/devinet.c:136 in my case. Happened altogether three times in >> the last few days and they all look the same: >> >> Nov 5 17:31:35 arch kernel: WARNING: at net/ipv4/devinet.c:136 in_dev_finish_destroy+0x5c/0x90() >> Nov 5 17:31:35 arch kernel: Hardware name: System Product Name >> Nov 5 17:31:35 arch kernel: Pid: 0, comm: kworker/0:1 Not tainted 2.6.37-rc1-00027-gff8b16d-dirty #4 >> Nov 5 17:31:35 arch kernel: Call Trace: >> Nov 5 17:31:35 arch kernel: <IRQ> [<ffffffff8105c9f6>] ? warn_slowpath_common+0x76/0xc0 >> Nov 5 17:31:35 arch kernel: [<ffffffff8141889c>] ? in_dev_finish_destroy+0x5c/0x90 >> Nov 5 17:31:35 arch kernel: [<ffffffff813c49e8>] ? dst_destroy+0x68/0x120 >> Nov 5 17:31:35 arch kernel: [<ffffffff813e888f>] ? dst_rcu_free+0x1f/0x30 >> Nov 5 17:31:35 arch kernel: [<ffffffff81090e0c>] ? __rcu_process_callbacks+0xfc/0x2f0 >> Nov 5 17:31:35 arch kernel: [<ffffffff8109103f>] ? rcu_process_callbacks+0x3f/0x70 >> Nov 5 17:31:35 arch kernel: [<ffffffff810621bc>] ? __do_softirq+0x9c/0x120 >> Nov 5 17:31:35 arch kernel: [<ffffffff81030fc9>] ? timer_interrupt+0x19/0x30 >> Nov 5 17:31:35 arch kernel: [<ffffffff8102ea4c>] ? call_softirq+0x1c/0x30 >> Nov 5 17:31:35 arch kernel: [<ffffffff8103080d>] ? do_softirq+0x4d/0x80 >> Nov 5 17:31:35 arch kernel: [<ffffffff8106232d>] ? irq_exit+0x8d/0x90 >> Nov 5 17:31:35 arch kernel: [<ffffffff810306c7>] ? do_IRQ+0x67/0xe0 >> Nov 5 17:31:35 arch kernel: [<ffffffff8144a153>] ? ret_from_intr+0x0/0xa >> Nov 5 17:31:35 arch kernel: <EOI> [<ffffffff81035ba0>] ? default_idle+0x20/0x40 >> Nov 5 17:31:35 arch kernel: [<ffffffff81035c12>] ? c1e_idle+0x52/0xf0 >> Nov 5 17:31:35 arch kernel: [<ffffffff8102c12c>] ? cpu_idle+0x4c/0xa0 >> Nov 5 17:31:35 arch kernel: ---[ end trace 143683935de8f41f ]--- >> Nov 5 17:31:35 arch kernel: Freeing alive in_device ffff88011ffba600 >> > > Hmm.... > > Is commit 1f1b9c9990205759aae31b7734b0ede41a867f32 present in your > kernel ? (fib: fib_result_assign() should not change fib refcounts) > > Could you provide some information ? > > ifconfig -a > > ip ro > > Thanks > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() 2010-11-08 20:46 ` Eric Dumazet 2010-11-08 20:50 ` Miles Lane @ 2010-11-08 20:55 ` Markus Trippelsdorf 2010-11-08 21:15 ` [PATCH] inet: fix ip_mc_drop_socket() Eric Dumazet 1 sibling, 1 reply; 9+ messages in thread From: Markus Trippelsdorf @ 2010-11-08 20:55 UTC (permalink / raw) To: Eric Dumazet; +Cc: paulmck, Miles Lane, ilpo.jarvinen, LKML, Len Brown, netdev On Mon, Nov 08, 2010 at 09:46:31PM +0100, Eric Dumazet wrote: > Le lundi 08 novembre 2010 à 21:42 +0100, Markus Trippelsdorf a écrit : > > On Mon, Nov 08, 2010 at 09:29:26PM +0100, Eric Dumazet wrote: > > > Le lundi 08 novembre 2010 à 12:06 -0800, Paul E. McKenney a écrit : > > > > On Mon, Nov 08, 2010 at 02:56:06PM -0500, Miles Lane wrote: > > > > > WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() > > > > > > > > Ilpo, thoughts? > > > > > > > > > > Hmm... > > > > > > WARN_ON(idev->mc_list); > > > > > > Might be a problem with refcounts somewhere... > > > > I have similar warnings in my logs, although its at > > net/ipv4/devinet.c:136 in my case. Happened altogether three times in > > the last few days and they all look the same: > > > > Nov 5 17:31:35 arch kernel: WARNING: at net/ipv4/devinet.c:136 in_dev_finish_destroy+0x5c/0x90() > > Nov 5 17:31:35 arch kernel: Hardware name: System Product Name > > Nov 5 17:31:35 arch kernel: Pid: 0, comm: kworker/0:1 Not tainted 2.6.37-rc1-00027-gff8b16d-dirty #4 > > Nov 5 17:31:35 arch kernel: Call Trace: > > Nov 5 17:31:35 arch kernel: <IRQ> [<ffffffff8105c9f6>] ? warn_slowpath_common+0x76/0xc0 > > Nov 5 17:31:35 arch kernel: [<ffffffff8141889c>] ? in_dev_finish_destroy+0x5c/0x90 > > Nov 5 17:31:35 arch kernel: [<ffffffff813c49e8>] ? dst_destroy+0x68/0x120 > > Nov 5 17:31:35 arch kernel: [<ffffffff813e888f>] ? dst_rcu_free+0x1f/0x30 > > Nov 5 17:31:35 arch kernel: [<ffffffff81090e0c>] ? __rcu_process_callbacks+0xfc/0x2f0 > > Nov 5 17:31:35 arch kernel: [<ffffffff8109103f>] ? rcu_process_callbacks+0x3f/0x70 > > Nov 5 17:31:35 arch kernel: [<ffffffff810621bc>] ? __do_softirq+0x9c/0x120 > > Nov 5 17:31:35 arch kernel: [<ffffffff81030fc9>] ? timer_interrupt+0x19/0x30 > > Nov 5 17:31:35 arch kernel: [<ffffffff8102ea4c>] ? call_softirq+0x1c/0x30 > > Nov 5 17:31:35 arch kernel: [<ffffffff8103080d>] ? do_softirq+0x4d/0x80 > > Nov 5 17:31:35 arch kernel: [<ffffffff8106232d>] ? irq_exit+0x8d/0x90 > > Nov 5 17:31:35 arch kernel: [<ffffffff810306c7>] ? do_IRQ+0x67/0xe0 > > Nov 5 17:31:35 arch kernel: [<ffffffff8144a153>] ? ret_from_intr+0x0/0xa > > Nov 5 17:31:35 arch kernel: <EOI> [<ffffffff81035ba0>] ? default_idle+0x20/0x40 > > Nov 5 17:31:35 arch kernel: [<ffffffff81035c12>] ? c1e_idle+0x52/0xf0 > > Nov 5 17:31:35 arch kernel: [<ffffffff8102c12c>] ? cpu_idle+0x4c/0xa0 > > Nov 5 17:31:35 arch kernel: ---[ end trace 143683935de8f41f ]--- > > Nov 5 17:31:35 arch kernel: Freeing alive in_device ffff88011ffba600 > > > > Hmm.... > > Is commit 1f1b9c9990205759aae31b7734b0ede41a867f32 present in your > kernel ? (fib: fib_result_assign() should not change fib refcounts) Yes, the last warning happend today on the lastest git kernel (from today). > > Could you provide some information ? > > ifconfig -a dummy0 Link encap:Ethernet HWaddr 76:FE:79:D4:80:DF BROADCAST NOARP MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:0 (0.0 b) TX bytes:0 (0.0 b) eth0 Link encap:Ethernet HWaddr 00:08:54:36:F2:2F inet addr:192.168.1.2 Bcast:192.168.1.255 Mask:255.255.255.0 UP BROADCAST RUNNING MULTICAST MTU:1492 Metric:1 RX packets:1945 errors:0 dropped:0 overruns:0 frame:0 TX packets:1450 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:1910343 (1.8 Mb) TX bytes:177533 (173.3 Kb) Interrupt:20 Base address:0x6c00 lo Link encap:Local Loopback inet addr:127.0.0.1 Mask:255.0.0.0 UP LOOPBACK RUNNING MTU:16436 Metric:1 RX packets:18321 errors:0 dropped:0 overruns:0 frame:0 TX packets:18321 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:2200368 (2.0 Mb) TX bytes:2200368 (2.0 Mb) > ip ro 192.168.1.0/24 dev eth0 proto kernel scope link src 192.168.1.2 default via 192.168.1.1 dev eth0 -- Markus ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] inet: fix ip_mc_drop_socket() 2010-11-08 20:55 ` Markus Trippelsdorf @ 2010-11-08 21:15 ` Eric Dumazet 2010-11-09 4:20 ` Miles Lane 2010-11-09 16:26 ` David Miller 0 siblings, 2 replies; 9+ messages in thread From: Eric Dumazet @ 2010-11-08 21:15 UTC (permalink / raw) To: Markus Trippelsdorf, David Miller Cc: paulmck, Miles Lane, ilpo.jarvinen, LKML, Len Brown, netdev Hmm, I believe I found the bug. Thanks guys ! [PATCH] inet: fix ip_mc_drop_socket() commit 8723e1b4ad9be4444 (inet: RCU changes in inetdev_by_index()) forgot one call site in ip_mc_drop_socket() We should not decrease idev refcount after inetdev_by_index() call, since refcount is not increased anymore. Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de> Reported-by: Miles Lane <miles.lane@gmail.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- net/ipv4/igmp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index c8877c6..3c53c2d 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c @@ -2306,10 +2306,8 @@ void ip_mc_drop_socket(struct sock *sk) in_dev = inetdev_by_index(net, iml->multi.imr_ifindex); (void) ip_mc_leave_src(sk, iml, in_dev); - if (in_dev != NULL) { + if (in_dev != NULL) ip_mc_dec_group(in_dev, iml->multi.imr_multiaddr.s_addr); - in_dev_put(in_dev); - } /* decrease mem now to avoid the memleak warning */ atomic_sub(sizeof(*iml), &sk->sk_omem_alloc); call_rcu(&iml->rcu, ip_mc_socklist_reclaim); ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] inet: fix ip_mc_drop_socket() 2010-11-08 21:15 ` [PATCH] inet: fix ip_mc_drop_socket() Eric Dumazet @ 2010-11-09 4:20 ` Miles Lane 2010-11-09 16:26 ` David Miller 1 sibling, 0 replies; 9+ messages in thread From: Miles Lane @ 2010-11-09 4:20 UTC (permalink / raw) To: Eric Dumazet Cc: Markus Trippelsdorf, David Miller, paulmck, ilpo.jarvinen, LKML, Len Brown, netdev Looks good here. On Mon, Nov 8, 2010 at 4:15 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Hmm, I believe I found the bug. > > Thanks guys ! > > [PATCH] inet: fix ip_mc_drop_socket() > > commit 8723e1b4ad9be4444 (inet: RCU changes in inetdev_by_index()) > forgot one call site in ip_mc_drop_socket() > > We should not decrease idev refcount after inetdev_by_index() call, > since refcount is not increased anymore. > > Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de> > Reported-by: Miles Lane <miles.lane@gmail.com> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > --- > net/ipv4/igmp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c > index c8877c6..3c53c2d 100644 > --- a/net/ipv4/igmp.c > +++ b/net/ipv4/igmp.c > @@ -2306,10 +2306,8 @@ void ip_mc_drop_socket(struct sock *sk) > > in_dev = inetdev_by_index(net, iml->multi.imr_ifindex); > (void) ip_mc_leave_src(sk, iml, in_dev); > - if (in_dev != NULL) { > + if (in_dev != NULL) > ip_mc_dec_group(in_dev, iml->multi.imr_multiaddr.s_addr); > - in_dev_put(in_dev); > - } > /* decrease mem now to avoid the memleak warning */ > atomic_sub(sizeof(*iml), &sk->sk_omem_alloc); > call_rcu(&iml->rcu, ip_mc_socklist_reclaim); > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] inet: fix ip_mc_drop_socket() 2010-11-08 21:15 ` [PATCH] inet: fix ip_mc_drop_socket() Eric Dumazet 2010-11-09 4:20 ` Miles Lane @ 2010-11-09 16:26 ` David Miller 1 sibling, 0 replies; 9+ messages in thread From: David Miller @ 2010-11-09 16:26 UTC (permalink / raw) To: eric.dumazet Cc: markus, paulmck, miles.lane, ilpo.jarvinen, linux-kernel, lenb, netdev From: Eric Dumazet <eric.dumazet@gmail.com> Date: Mon, 08 Nov 2010 22:15:54 +0100 > Hmm, I believe I found the bug. > > Thanks guys ! > > [PATCH] inet: fix ip_mc_drop_socket() > > commit 8723e1b4ad9be4444 (inet: RCU changes in inetdev_by_index()) > forgot one call site in ip_mc_drop_socket() > > We should not decrease idev refcount after inetdev_by_index() call, > since refcount is not increased anymore. > > Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de> > Reported-by: Miles Lane <miles.lane@gmail.com> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Applied, thanks a lot! ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-11-09 16:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AANLkTinVyf4CpxdzEWUn7zTyOrAMKY3H9Dct-HfopiSD@mail.gmail.com>
2010-11-08 20:06 ` 2.6.37-rc1-git5 -- WARNING: at net/ipv4/devinet.c:137 in_dev_finish_destroy+0x3d/0x6e() Paul E. McKenney
2010-11-08 20:29 ` Eric Dumazet
2010-11-08 20:42 ` Markus Trippelsdorf
2010-11-08 20:46 ` Eric Dumazet
2010-11-08 20:50 ` Miles Lane
2010-11-08 20:55 ` Markus Trippelsdorf
2010-11-08 21:15 ` [PATCH] inet: fix ip_mc_drop_socket() Eric Dumazet
2010-11-09 4:20 ` Miles Lane
2010-11-09 16:26 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).