From: David Miller <davem@davemloft.net>
To: xiaohui.xin@intel.com
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
herbert@gondor.apana.org.au, jdike@linux.intel.com
Subject: Re: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net.
Date: Wed, 10 Nov 2010 09:46:41 -0800 (PST) [thread overview]
Message-ID: <20101110.094641.193701683.davem@davemloft.net> (raw)
In-Reply-To: <1289381008-5484-1-git-send-email-xiaohui.xin@intel.com>
From: xiaohui.xin@intel.com
Date: Wed, 10 Nov 2010 17:23:28 +0800
> From: Xin Xiaohui <xiaohui.xin@intel.com>
>
>>2) The idea to key off of skb->dev in skb_release_data() is
>> fundamentally flawed since many actions can change skb->dev on you,
>> which will end up causing a leak of your external data areas.
>
> How about this one? If the destructor_arg is not a good candidate,
> then I have to add an apparent field in shinfo.
If destructor_arg is actually a net_device pointer or similar,
you will need to take a reference count on it or similar.
Which means --> good bye performance especially on SMP.
You're going to be adding new serialization points and at
least two new atomics per packet.
next prev parent reply other threads:[~2010-11-10 17:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 9:03 [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 01/17] Add a new structure for skb buffer from external xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 02/17]Add a new struct for device to manipulate external buffer xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 03/17]Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 04/17]Add a function make external buffer owner to query capability xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 05/17] Add a function to indicate if device use external buffer xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 06/17] Use callback to deal with skb_release_data() specially xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 07/17]Modify netdev_alloc_page() to get external buffer xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 08/17]Modify netdev_free_page() to release " xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 09/17] Don't do skb recycle, if device use " xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 10/17]If device is in zero-copy mode first, bonding will fail xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 11/17] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 12/17] Add header file for mp device xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 13/17] Add mp(mediate passthru) device xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 14/17]Add a kconfig entry and make entry for mp device xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 15/17] Provides multiple submits and asynchronous notifications xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 16/17] An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-11-09 9:03 ` [PATCH v15 17/17] An example how to alloc user buffer based on " xiaohui.xin
2010-11-09 17:15 ` [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net David Miller
2010-11-10 9:23 ` xiaohui.xin
2010-11-10 17:46 ` David Miller [this message]
2010-11-11 8:28 ` Xin, Xiaohui
2010-11-17 8:09 ` Xin, Xiaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110.094641.193701683.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).