From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: urs@isnogud.escape.de, netdev@vger.kernel.org,
drosenberg@vsecurity.com, security@kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] Fix CAN info leak/minor heap overflow
Date: Wed, 10 Nov 2010 09:51:41 -0800 (PST) [thread overview]
Message-ID: <20101110.095141.226780406.davem@davemloft.net> (raw)
In-Reply-To: <4CDA412B.90900@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Wed, 10 Nov 2010 07:52:27 +0100
> IMHO the patch improves the historic situation and fixes the useless leakage
> of kernel addresses. Please consider to apply that procfs changes.
I'm only fine with fixing the kernel pointer fields in some way.
But moving forward any other change to the procfs file is simply
a waste of time.
You should create sysfs files and add logic to your tools to look
for them and use them if they exist.
Your forward path _SHOULD NOT_ be continuing this procfs versioning
madness. Use something sane and do the work to make userland start
to be ready for this transition.
next prev parent reply other threads:[~2010-11-10 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 18:28 [SECURITY] CAN info leak/minor heap overflow Dan Rosenberg
2010-11-02 19:43 ` Oliver Hartkopp
2010-11-02 19:53 ` Dan Rosenberg
2010-11-02 19:57 ` [Security] " Linus Torvalds
2010-11-02 20:19 ` Oliver Hartkopp
2010-11-02 20:16 ` Oliver Hartkopp
2010-11-05 18:33 ` [PATCH] Fix " Urs Thuermann
2010-11-09 7:52 ` Oliver Hartkopp
2010-11-09 17:05 ` David Miller
2010-11-10 6:52 ` Oliver Hartkopp
2010-11-10 17:51 ` David Miller [this message]
2010-11-10 22:10 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110.095141.226780406.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=torvalds@linux-foundation.org \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).