* [PATCH] Fix header size check for GSO case in recvmsg (af_packet)
@ 2010-11-08 21:58 Mariusz Kozlowski
2010-11-10 20:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Kozlowski @ 2010-11-08 21:58 UTC (permalink / raw)
To: Sridhar Samudrala
Cc: David S. Miller, netdev, linux-kernel, Mariusz Kozlowski
Parameter 'len' is size_t type so it will never get negative.
Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>
---
net/packet/af_packet.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 3616f27..3451191 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -1610,9 +1610,11 @@ static int packet_recvmsg(struct kiocb *iocb, struct socket *sock,
err = -EINVAL;
vnet_hdr_len = sizeof(vnet_hdr);
- if ((len -= vnet_hdr_len) < 0)
+ if (len < vnet_hdr_len)
goto out_free;
+ len -= vnet_hdr_len;
+
if (skb_is_gso(skb)) {
struct skb_shared_info *sinfo = skb_shinfo(skb);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix header size check for GSO case in recvmsg (af_packet)
2010-11-08 21:58 [PATCH] Fix header size check for GSO case in recvmsg (af_packet) Mariusz Kozlowski
@ 2010-11-10 20:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-11-10 20:53 UTC (permalink / raw)
To: mk; +Cc: sri, netdev, linux-kernel
From: Mariusz Kozlowski <mk@lab.zgora.pl>
Date: Mon, 8 Nov 2010 22:58:45 +0100
> Parameter 'len' is size_t type so it will never get negative.
>
> Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>
Applied, thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-10 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-08 21:58 [PATCH] Fix header size check for GSO case in recvmsg (af_packet) Mariusz Kozlowski
2010-11-10 20:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).