From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] neigh: reorder struct neighbour
Date: Thu, 11 Nov 2010 10:41:38 -0800 (PST) [thread overview]
Message-ID: <20101111.104138.59661151.davem@davemloft.net> (raw)
In-Reply-To: <1289494639.17691.1499.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 11 Nov 2010 17:57:19 +0100
> It is important to move nud_state outside of the often modified cache
> line (because of refcnt), to reduce false sharing in neigh_event_send()
>
> This is a followup of commit 0ed8ddf4045f (neigh: Protect neigh->ha[]
> with a seqlock)
>
> This gives a 7% speedup on routing test with IP route cache disabled.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> David, it appears I forgot to push this patch, I have it in my tree
> since one month. Thanks !
Applied, thanks.
prev parent reply other threads:[~2010-11-11 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 16:57 [PATCH] neigh: reorder struct neighbour Eric Dumazet
2010-11-11 18:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111.104138.59661151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).