From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org,
rolandd@cisco.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com
Subject: Re: [PATCH net-next-2.6] net: get rid of rtable->idev
Date: Thu, 11 Nov 2010 10:41:53 -0800 (PST) [thread overview]
Message-ID: <20101111.104153.115922255.davem@davemloft.net> (raw)
In-Reply-To: <1289495647.17691.1536.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 11 Nov 2010 18:14:07 +0100
> It seems idev field in struct rtable has no special purpose, but adding
> extra atomic ops.
>
> We hold refcounts on the device itself (using percpu data, so pretty
> cheap in current kernel).
>
> infiniband case is solved using dst.dev instead of idev->dev
>
> Removal of this field means routing without route cache is now using
> shared data, percpu data, and only potential contention is a pair of
> atomic ops on struct neighbour per forwarded packet.
>
> About 5% speedup on routing test.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Roland Dreier <rolandd@cisco.com>
> Cc: Sean Hefty <sean.hefty@intel.com>
> Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Yes, let's remove as much unused crap as possible :-)
Applied, thanks!
prev parent reply other threads:[~2010-11-11 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 17:14 [PATCH net-next-2.6] net: get rid of rtable->idev Eric Dumazet
2010-11-11 18:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111.104153.115922255.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hal.rosenstock@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).