From: Stephen Hemminger <shemminger@vyatta.com>
To: Dan Rosenberg <drosenberg@vsecurity.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Urs Thuermann <urs.thuermann@volkswagen.de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
James Morris <jmorris@namei.org>,
Remi Denis-Courmont <remi.denis-courmont@nokia.com>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
Sridhar Samudrala <sri@us.ibm.com>,
Vlad Yasevich <vladislav.yasevich@hp.com>,
Tejun Heo <tj@kernel.org>, Eric Dumazet <eric.dumazet@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>, Joe Perches <joe@perches.com>,
Jamal Hadi Salim <hadi@mojatatu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Jiri Pirko <jpirko@redhat.com>,
Johannes Berg <johannes.berg@intel.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Pavel Emelyanov <xemul@openvz.org>,
socketcan-core@l
Subject: Re: [PATCH 2/10] Fix leaking of kernel heap addresses in net/
Date: Thu, 11 Nov 2010 17:17:54 -0800 [thread overview]
Message-ID: <20101111171754.0198e151@nehalam> (raw)
In-Reply-To: <1289524019.5167.66.camel@dan>
On Thu, 11 Nov 2010 20:06:59 -0500
Dan Rosenberg <drosenberg@vsecurity.com> wrote:
> diff --git a/net/can/bcm.c b/net/can/bcm.c
> index 08ffe9e..5960ad7 100644
> --- a/net/can/bcm.c
> +++ b/net/can/bcm.c
> @@ -165,9 +165,16 @@ static int bcm_proc_show(struct seq_file *m, void *v)
> struct bcm_sock *bo = bcm_sk(sk);
> struct bcm_op *op;
>
> - seq_printf(m, ">>> socket %p", sk->sk_socket);
> - seq_printf(m, " / sk %p", sk);
> - seq_printf(m, " / bo %p", bo);
> + /* Only expose kernel addresses to privileged readers */
> + if (capable(CAP_NET_ADMIN))
> + seq_printf(m, ">>> socket %p", sk->sk_socket);
> + seq_printf(m, " / sk %p", sk);
> + seq_printf(m, " / bo %p", bo);
> + else
> + seq_printf(m, ">>> socket %lu", sock_i_ino(sk));
> + seq_printf(m, " / sk %d", 0);
> + seq_printf(m, " / bo %d", 0);
> +
Printing different data based on security state seems like an ABI
nightmare.
--
next prev parent reply other threads:[~2010-11-12 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 1:06 [PATCH 2/10] Fix leaking of kernel heap addresses in net/ Dan Rosenberg
2010-11-12 1:17 ` Stephen Hemminger [this message]
2010-11-12 1:22 ` Dan Rosenberg
2010-11-12 15:09 ` Ben Hutchings
2010-11-12 15:11 ` Dan Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111171754.0198e151@nehalam \
--to=shemminger@vyatta.com \
--cc=adobriyan@gmail.com \
--cc=daniel.lezcano@free.fr \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=hadi@mojatatu.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=lizf@cn.fujitsu.com \
--cc=pekkas@netcore.fi \
--cc=remi.denis-courmont@nokia.com \
--cc=socketcan-core@l \
--cc=socketcan@hartkopp.net \
--cc=sri@us.ibm.com \
--cc=tj@kernel.org \
--cc=urs.thuermann@volkswagen.de \
--cc=vladislav.yasevich@hp.com \
--cc=xemul@openvz.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox