From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: netdev@vger.kernel.org, hzheng@nicira.com,
jeffrey.t.kirsher@intel.com, alexander.h.duyck@intel.com,
jesse.brandeburg@intel.com
Subject: Re: [PATCH net-2.6 v2 3/3] ixgbe: Look inside vlan when determining offload protocol.
Date: Fri, 12 Nov 2010 12:24:33 -0800 (PST) [thread overview]
Message-ID: <20101112.122433.115917799.davem@davemloft.net> (raw)
In-Reply-To: <1289519279-20641-3-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Thu, 11 Nov 2010 15:47:59 -0800
> From: Hao Zheng <hzheng@nicira.com>
>
> Currently the skb->protocol field is used to setup various
> offloading parameters on transmit for the correct protocol.
> However, if vlan offloading is disabled or otherwise not used,
> the protocol field will be ETH_P_8021Q, not the actual protocol.
> This will cause the offloading to be not performed correctly,
> even though the hardware is capable of looking inside vlan tags.
> Instead, look inside the header if necessary to determine the
> correct protocol type.
>
> To some extent this fixes a regression from 2.6.36 because it
> was previously not possible to disable vlan offloading and this
> error case was not exposed.
>
> Signed-off-by: Hao Zheng <hzheng@nicira.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Alex Duyck <alexander.h.duyck@intel.com>
> CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
Applied.
next prev parent reply other threads:[~2010-11-12 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 23:47 [PATCH net-2.6 v2 1/3] vlan: Add function to retrieve EtherType from vlan packets Jesse Gross
2010-11-11 23:47 ` [PATCH net-2.6 v2 2/3] bnx2x: Look inside vlan when determining checksum proto Jesse Gross
2010-11-12 20:24 ` David Miller
2010-11-11 23:47 ` [PATCH net-2.6 v2 3/3] ixgbe: Look inside vlan when determining offload protocol Jesse Gross
2010-11-12 20:24 ` David Miller [this message]
2010-11-12 20:24 ` [PATCH net-2.6 v2 1/3] vlan: Add function to retrieve EtherType from vlan packets David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112.122433.115917799.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=hzheng@nicira.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).