From: David Miller <davem@davemloft.net>
To: drosenberg@vsecurity.com
Cc: andrew.hendry@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] Prevent crashing when parsing bad X.25 facilities
Date: Fri, 12 Nov 2010 12:29:46 -0800 (PST) [thread overview]
Message-ID: <20101112.122946.102556009.davem@davemloft.net> (raw)
In-Reply-To: <1289570877.3090.274.camel@Dan>
From: Dan Rosenberg <drosenberg@vsecurity.com>
Date: Fri, 12 Nov 2010 09:07:57 -0500
> @@ -149,9 +157,8 @@ int x25_parse_facilities(struct sk_buff *skb, struct x25_facilities *facilities,
> break;
> default:
> printk(KERN_DEBUG "X.25: unknown facility %02X,"
> - "length %d, values %02X, %02X, "
> - "%02X, %02X\n",
> - p[0], p[1], p[2], p[3], p[4], p[5]);
> + "length %d\n"
> + p[0], p[1]);
> break;
Thanks for not even compile testing your changes:
net/x25/x25_facilities.c: In function 'x25_parse_facilities':
net/x25/x25_facilities.c:161:6: error: expected ')' before 'p'
net/x25/x25_facilities.c:161:6: warning: too few arguments for format
I find this kind of carelessness extremely amusing coming from someone
who is so big on security theatre.
next prev parent reply other threads:[~2010-11-12 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 14:07 [PATCH v2] Prevent crashing when parsing bad X.25 facilities Dan Rosenberg
2010-11-12 20:29 ` David Miller [this message]
2010-11-12 20:44 ` Dan Rosenberg
2010-11-12 20:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112.122946.102556009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.hendry@gmail.com \
--cc=drosenberg@vsecurity.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).