From: David Miller <davem@davemloft.net>
To: shanwei@cn.fujitsu.com
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: fix checksum broken
Date: Fri, 12 Nov 2010 12:44:01 -0800 (PST) [thread overview]
Message-ID: <20101112.124401.35026128.davem@davemloft.net> (raw)
In-Reply-To: <4CDD13BD.7060109@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Fri, 12 Nov 2010 18:15:25 +0800
> If r8196 received packets with invalid sctp/igmp(not tcp, udp) checksum, r8196 set skb->ip_summed
> wit CHECKSUM_UNNECESSARY. This cause that upper protocol don't check checksum field.
>
> I am not family with r8196 driver. I try to guess the meaning of RxProtoIP and IPFail.
> RxProtoIP stands for received IPv4 packet that upper protocol is not tcp and udp.
> !(opts1 & IPFail) is true means that driver correctly to check checksum in IPv4 header.
>
> If it's right, I think we should not set ip_summed wit CHECKSUM_UNNECESSARY for my sctp packets
> with invalid checksum.
>
> If it's not right, please tell me.
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Francois, please review, it looks correct to my eyes.
next prev parent reply other threads:[~2010-11-12 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 10:15 [PATCH] r8169: fix checksum broken Shan Wei
2010-11-12 20:44 ` David Miller [this message]
2010-11-12 22:47 ` Francois Romieu
2010-11-12 23:13 ` Francois Romieu
2010-11-15 3:31 ` Shan Wei
2010-11-15 21:01 ` Francois Romieu
2010-11-17 19:55 ` David Miller
2010-11-17 19:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112.124401.35026128.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).