From: David Miller <davem@davemloft.net>
To: rjw@sisk.pl
Cc: daniel.blueman@gmail.com, romieu@fr.zoreil.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] gianfar: Do not call device_set_wakeup_enable() under a spinlock
Date: Fri, 12 Nov 2010 14:06:13 -0800 (PST) [thread overview]
Message-ID: <20101112.140613.45885023.davem@davemloft.net> (raw)
In-Reply-To: <201011092254.19550.rjw@sisk.pl>
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Tue, 9 Nov 2010 22:54:19 +0100
> The gianfar driver calls device_set_wakeup_enable() under a spinlock,
> which causes a problem to happen after the recent core power
> management changes, because this function can sleep now. Fix this
> by moving the device_set_wakeup_enable() call out of the
> spinlock-protected area.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Patch applied, thank you.
prev parent reply other threads:[~2010-11-12 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTimf_mVrRPEcj8qBbYw1iYHfWdeKUNS3Kk-dfhTT@mail.gmail.com>
2010-11-08 23:30 ` [2.6.37-rc1, patch] gianfar: fix sleep in atomic Rafael J. Wysocki
2010-11-09 21:54 ` [PATCH] gianfar: Do not call device_set_wakeup_enable() under a spinlock Rafael J. Wysocki
2010-11-12 22:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112.140613.45885023.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.blueman@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).