From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] bridge: add __rcu annotations
Date: Sat, 13 Nov 2010 09:35:45 -0800 [thread overview]
Message-ID: <20101113093545.6fe9c077@nehalam> (raw)
In-Reply-To: <1289636128.2743.15.camel@edumazet-laptop>
On Sat, 13 Nov 2010 09:15:28 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 578debb..ffbd177 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -996,7 +996,10 @@ struct net_device {
> #endif
>
> rx_handler_func_t *rx_handler;
> - void *rx_handler_data;
> + union {
> + void *rx_handler_data;
> + struct net_bridge_port __rcu *br_port_rcu;
> + };
>
> struct netdev_queue __rcu *ingress_queue;
I don't like making the generic hook typed again.
We don't do this for other callbacks, timers, workqueues, ...
Why is it necessary for RCU notation.
--
next prev parent reply other threads:[~2010-11-13 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-13 8:15 [PATCH net-next-2.6] bridge: add __rcu annotations Eric Dumazet
2010-11-13 17:35 ` Stephen Hemminger [this message]
2010-11-13 17:58 ` Eric Dumazet
2010-11-13 18:13 ` Stephen Hemminger
2010-11-13 22:04 ` Eric Dumazet
2010-11-14 18:47 ` Stephen Hemminger
2010-11-16 12:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101113093545.6fe9c077@nehalam \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).