From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: john.r.fastabend@intel.com, netdev@vger.kernel.org,
eric.dumazet@gmail.com
Subject: Re: [net-2.6 PATCH] nete zero kobject in rx_queue_release
Date: Sun, 14 Nov 2010 15:15:29 -0800 (PST) [thread overview]
Message-ID: <20101114.151529.183053743.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTi=1Xzne6HZN-w_3RTeUmqtjGpHPfW211SKvW17w@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Sun, 14 Nov 2010 14:40:00 -0800
>> So we'll need something like:
>>
>> if (atomic_dec_and_test(&first->count))
>> kfree(first);
>> else
>> /* clear everything except queue->first */
>>
>
> The patches to get rid of the separate refcnt should obviate this
> complexity. Could just clear the queue in kobject release.
True but we'll still need a patch for older kernels.
next prev parent reply other threads:[~2010-11-14 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 20:13 [net-2.6 PATCH] nete zero kobject in rx_queue_release John Fastabend
2010-11-12 21:08 ` David Miller
2010-11-14 22:40 ` Tom Herbert
2010-11-14 23:15 ` David Miller [this message]
2010-11-16 2:06 ` John Fastabend
2010-11-16 7:13 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114.151529.183053743.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).