From: David Miller <davem@davemloft.net>
To: bhatewara@vmware.com
Cc: netdev@vger.kernel.org
Subject: vmxnet3 multiqueue
Date: Mon, 15 Nov 2010 10:16:49 -0800 (PST) [thread overview]
Message-ID: <20101115.101649.245385009.davem@davemloft.net> (raw)
Two things:
1) Do not quote the entire patch when asking for feedback,
that adds needless scrolling for people trying to read
through either the thread on an archive site or me trying
to skim through the feedback in the patchwork entry.
You are not adding any new information at all by quoting
the entire patch, and in fact you are making it more difficult
for the very people you want replies from.
2) You're still adding driver specific module option knobs
which we have consistently stated are not to be added to
any driver. Instead create generic facilities that any
driver, not just your's, can make use of.
For now I would simply rip out the module option knobs and
submit the simplest patch possible which always turns on
multiqueue and never acts conditionally.
You can add the knobs via a kernel wide facility later.
reply other threads:[~2010-11-15 18:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115.101649.245385009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhatewara@vmware.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).