netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* vmxnet3 multiqueue
@ 2010-11-15 18:16 David Miller
  0 siblings, 0 replies; only message in thread
From: David Miller @ 2010-11-15 18:16 UTC (permalink / raw)
  To: bhatewara; +Cc: netdev


Two things:

1) Do not quote the entire patch when asking for feedback,
   that adds needless scrolling for people trying to read
   through either the thread on an archive site or me trying
   to skim through the feedback in the patchwork entry.

   You are not adding any new information at all by quoting
   the entire patch, and in fact you are making it more difficult
   for the very people you want replies from.

2) You're still adding driver specific module option knobs
   which we have consistently stated are not to be added to
   any driver.  Instead create generic facilities that any
   driver, not just your's, can make use of.

For now I would simply rip out the module option knobs and
submit the simplest patch possible which always turns on
multiqueue and never acts conditionally.

You can add the knobs via a kernel wide facility later.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-11-15 18:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-15 18:16 vmxnet3 multiqueue David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).