[PATCH 0/2] net: Changes in queue allocation and freeing

[PATCH 0/2] net: Changes in queue allocation and freeing

[Tom Herbert]

Changes to both RX and TX queue allocation.  In both cases allocate
in alloc_netdev_mq and free in free_netdev.  For RX the reference
couting also changed, the device reference count can now be used.

Re: [PATCH 0/2] net: Changes in queue allocation and freeing

[Eric Dumazet]

Le mardi 09 novembre 2010 à 12:47 -0800, Tom Herbert a écrit :
> Changes to both RX and TX queue allocation.  In both cases allocate
> in alloc_netdev_mq and free in free_netdev.  For RX the reference
> couting also changed, the device reference count can now be used.

Oh well :)

Are they preliminary patches so that XPS also dont need the "reference
counts specific to TX queues" ? ;)

Re: [PATCH 0/2] net: Changes in queue allocation and freeing

[Tom Herbert]

On Wed, Nov 10, 2010 at 2:41 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le mardi 09 novembre 2010 à 12:47 -0800, Tom Herbert a écrit :
>> Changes to both RX and TX queue allocation.  In both cases allocate
>> in alloc_netdev_mq and free in free_netdev.  For RX the reference
>> couting also changed, the device reference count can now be used.
>
> Oh well :)
>
> Are they preliminary patches so that XPS also dont need the "reference
> counts specific to TX queues" ? ;)
>
Yes, this should allow the xps maps to be in the net_device also.
Sorry I neglected to mention that.

Also I noticed that the comment about RX queues refcnts is no longer
valid.  I can respin patch if necessary.

diff --git a/net/core/dev.c b/net/core/dev.c
index 87d89ba..34a42a8 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5029,10 +5029,6 @@ static int netif_alloc_rx_queues(struct net_device *dev)
        }
        dev->_rx = rx;

-       /*
-        * Set a pointer to first element in the array which holds the
-        * reference count.
-        */
        for (i = 0; i < count; i++)
                rx[i].dev = dev;
 #endif

>
>
>

Re: [PATCH 0/2] net: Changes in queue allocation and freeing

[David Miller]

From: Tom Herbert <therbert@google.com>
Date: Wed, 10 Nov 2010 08:27:54 -0800

> Also I noticed that the comment about RX queues refcnts is no longer
> valid.  I can respin patch if necessary.

Not necessary, when I apply your patch I'll integrate this comment
removal.

Thanks.

Re: [PATCH 0/2] net: Changes in queue allocation and freeing

[David Miller]

From: Tom Herbert <therbert@google.com>
Date: Tue, 9 Nov 2010 12:47:26 -0800 (PST)

> Changes to both RX and TX queue allocation.  In both cases allocate
> in alloc_netdev_mq and free in free_netdev.  For RX the reference
> couting also changed, the device reference count can now be used.

Both applied, with the comment removal added as promised.

I assume you'll spin a new version of the XPS patches
against this?

Thanks!

Re: [PATCH 0/2] net: Changes in queue allocation and freeing

[Tom Herbert]

On Mon, Nov 15, 2010 at 10:58 AM, David Miller <davem@davemloft.net> wrote:
> From: Tom Herbert <therbert@google.com>
> Date: Tue, 9 Nov 2010 12:47:26 -0800 (PST)
>
>> Changes to both RX and TX queue allocation.  In both cases allocate
>> in alloc_netdev_mq and free in free_netdev.  For RX the reference
>> couting also changed, the device reference count can now be used.
>
> Both applied, with the comment removal added as promised.
>
Thanks.

> I assume you'll spin a new version of the XPS patches
> against this?
>

Yes, those will be forthcoming.

> Thanks!
>