* [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf
@ 2010-11-16 6:29 John Fastabend
2010-11-16 6:37 ` Eric Dumazet
2010-11-16 17:35 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: John Fastabend @ 2010-11-16 6:29 UTC (permalink / raw)
To: davem; +Cc: john.r.fastabend, eric.dumazet, netdev, shemminger
Fix ref count bug introduced by
commit 2de795707294972f6c34bae9de713e502c431296
Author: Lorenzo Colitti <lorenzo@google.com>
Date: Wed Oct 27 18:16:49 2010 +0000
ipv6: addrconf: don't remove address state on ifdown if the address
is being kept
Fix logic so that addrconf_ifdown() decrements the inet6_ifaddr
refcnt correctly with in6_ifa_put().
Reported-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/ipv6/addrconf.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index b41ce0f..aaa3ca4 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2754,13 +2754,13 @@ static int addrconf_ifdown(struct net_device *dev, int how)
ifa->state = INET6_IFADDR_STATE_DEAD;
spin_unlock_bh(&ifa->state_lock);
- if (state == INET6_IFADDR_STATE_DEAD) {
- in6_ifa_put(ifa);
- } else {
+ if (state != INET6_IFADDR_STATE_DEAD) {
__ipv6_ifa_notify(RTM_DELADDR, ifa);
atomic_notifier_call_chain(&inet6addr_chain,
NETDEV_DOWN, ifa);
}
+
+ in6_ifa_put(ifa);
write_lock_bh(&idev->lock);
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf
2010-11-16 6:29 [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf John Fastabend
@ 2010-11-16 6:37 ` Eric Dumazet
2010-11-17 15:20 ` Anders Franzen
2010-11-16 17:35 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2010-11-16 6:37 UTC (permalink / raw)
To: John Fastabend; +Cc: davem, netdev, shemminger
Le lundi 15 novembre 2010 à 22:29 -0800, John Fastabend a écrit :
> Fix ref count bug introduced by
>
> commit 2de795707294972f6c34bae9de713e502c431296
> Author: Lorenzo Colitti <lorenzo@google.com>
> Date: Wed Oct 27 18:16:49 2010 +0000
>
> ipv6: addrconf: don't remove address state on ifdown if the address
> is being kept
>
>
> Fix logic so that addrconf_ifdown() decrements the inet6_ifaddr
> refcnt correctly with in6_ifa_put().
>
> Reported-by: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
>
> net/ipv6/addrconf.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index b41ce0f..aaa3ca4 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2754,13 +2754,13 @@ static int addrconf_ifdown(struct net_device *dev, int how)
> ifa->state = INET6_IFADDR_STATE_DEAD;
> spin_unlock_bh(&ifa->state_lock);
>
> - if (state == INET6_IFADDR_STATE_DEAD) {
> - in6_ifa_put(ifa);
> - } else {
> + if (state != INET6_IFADDR_STATE_DEAD) {
> __ipv6_ifa_notify(RTM_DELADDR, ifa);
> atomic_notifier_call_chain(&inet6addr_chain,
> NETDEV_DOWN, ifa);
> }
> +
> + in6_ifa_put(ifa);
> write_lock_bh(&idev->lock);
> }
> }
>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Thanks again John
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf
2010-11-16 6:37 ` Eric Dumazet
@ 2010-11-17 15:20 ` Anders Franzen
2010-11-17 15:38 ` Eric Dumazet
0 siblings, 1 reply; 5+ messages in thread
From: Anders Franzen @ 2010-11-17 15:20 UTC (permalink / raw)
To: Eric Dumazet
Cc: John Fastabend, davem@davemloft.net, netdev@vger.kernel.org,
shemminger@vyatta.com
Hi, I was hunting for a bug that a colleague discovered.
When we exit a network namespace, the ns was hanging with dangling
references to dev lo.
When I saw the patch below, I fetched the latest net-next from Daves
repository.
And the problem is gone. Was this really the fix, since it seems to me
that this is a fix to a recently added patch (dont remove address ....).
Did you fix anything else in the Ipv6 addrconf w.r.g dev_hold/dev_put?
netns still have problems with slab corruption during exit though:
Nov 17 15:00:20 p04 user.err kernel: Slab corruption: size-4096
start=ffff88000612a000, len=4096
Nov 17 15:00:20 p04 user.err kernel: 020: 6b 6b 6b 6b 6b 6b
Nov 17 15:00:20 p04 user.info kernel: 6b 6b 00 00 00 00 00 00 00
Nov 17 15:00:20 p04 user.info kernel: 00
BR
Anders
On Tue, 2010-11-16 at 07:37 +0100, Eric Dumazet wrote:
> Le lundi 15 novembre 2010 à 22:29 -0800, John Fastabend a écrit :
> > Fix ref count bug introduced by
> >
> > commit 2de795707294972f6c34bae9de713e502c431296
> > Author: Lorenzo Colitti <lorenzo@google.com>
> > Date: Wed Oct 27 18:16:49 2010 +0000
> >
> > ipv6: addrconf: don't remove address state on ifdown if the address
> > is being kept
> >
> >
> > Fix logic so that addrconf_ifdown() decrements the inet6_ifaddr
> > refcnt correctly with in6_ifa_put().
> >
> > Reported-by: Stephen Hemminger <shemminger@vyatta.com>
> > Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> > ---
> >
> > net/ipv6/addrconf.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> > index b41ce0f..aaa3ca4 100644
> > --- a/net/ipv6/addrconf.c
> > +++ b/net/ipv6/addrconf.c
> > @@ -2754,13 +2754,13 @@ static int addrconf_ifdown(struct net_device *dev, int how)
> > ifa->state = INET6_IFADDR_STATE_DEAD;
> > spin_unlock_bh(&ifa->state_lock);
> >
> > - if (state == INET6_IFADDR_STATE_DEAD) {
> > - in6_ifa_put(ifa);
> > - } else {
> > + if (state != INET6_IFADDR_STATE_DEAD) {
> > __ipv6_ifa_notify(RTM_DELADDR, ifa);
> > atomic_notifier_call_chain(&inet6addr_chain,
> > NETDEV_DOWN, ifa);
> > }
> > +
> > + in6_ifa_put(ifa);
> > write_lock_bh(&idev->lock);
> > }
> > }
> >
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Thanks again John
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf
2010-11-17 15:20 ` Anders Franzen
@ 2010-11-17 15:38 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2010-11-17 15:38 UTC (permalink / raw)
To: Anders Franzen
Cc: John Fastabend, davem@davemloft.net, netdev@vger.kernel.org,
shemminger@vyatta.com
Le mercredi 17 novembre 2010 à 16:20 +0100, Anders Franzen a écrit :
> Hi, I was hunting for a bug that a colleague discovered.
> When we exit a network namespace, the ns was hanging with dangling
> references to dev lo.
>
> When I saw the patch below, I fetched the latest net-next from Daves
> repository.
>
> And the problem is gone. Was this really the fix, since it seems to me
> that this is a fix to a recently added patch (dont remove address ....).
>
> Did you fix anything else in the Ipv6 addrconf w.r.g dev_hold/dev_put?
>
> netns still have problems with slab corruption during exit though:
>
> Nov 17 15:00:20 p04 user.err kernel: Slab corruption: size-4096
> start=ffff88000612a000, len=4096
> Nov 17 15:00:20 p04 user.err kernel: 020: 6b 6b 6b 6b 6b 6b
> Nov 17 15:00:20 p04 user.info kernel: 6b 6b 00 00 00 00 00 00 00
> Nov 17 15:00:20 p04 user.info kernel: 00
>
> BR
> Anders
>
>
Hi Anders
Several patches of interest :
commit 9d82ca98f71fd686ef2f3017c5e3e6a4871b6e46
(ipv6: fix missing in6_ifa_put in addrconf)
commit 332dd96f7ac15e937088fe11f15cfe0210e8edd1
(net/dst: dst_dev_event() called after other notifiers)
commit ef885afbf8a37689afc1d9d545e2f3e7a8276c17
(net: use rcu_barrier() in rollback_registered_many)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf
2010-11-16 6:29 [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf John Fastabend
2010-11-16 6:37 ` Eric Dumazet
@ 2010-11-16 17:35 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2010-11-16 17:35 UTC (permalink / raw)
To: john.r.fastabend; +Cc: eric.dumazet, netdev, shemminger
From: John Fastabend <john.r.fastabend@intel.com>
Date: Mon, 15 Nov 2010 22:29:21 -0800
> Fix ref count bug introduced by
>
> commit 2de795707294972f6c34bae9de713e502c431296
> Author: Lorenzo Colitti <lorenzo@google.com>
> Date: Wed Oct 27 18:16:49 2010 +0000
>
> ipv6: addrconf: don't remove address state on ifdown if the address
> is being kept
>
>
> Fix logic so that addrconf_ifdown() decrements the inet6_ifaddr
> refcnt correctly with in6_ifa_put().
>
> Reported-by: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thanks a lot.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-17 15:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-16 6:29 [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf John Fastabend
2010-11-16 6:37 ` Eric Dumazet
2010-11-17 15:20 ` Anders Franzen
2010-11-17 15:38 ` Eric Dumazet
2010-11-16 17:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).