netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH net-next-2.6] vlan: lockless transmit path
Date: Tue, 16 Nov 2010 11:24:24 -0800 (PST)	[thread overview]
Message-ID: <20101116.112424.102532013.davem@davemloft.net> (raw)
In-Reply-To: <1289468520.17691.1018.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 11 Nov 2010 10:42:00 +0100

> vlan is a stacked device, like tunnels. We should use the lockless
> mechanism we are using in tunnels and loopback.
> 
> This patch completely removes locking in TX path.
> 
> tx stat counters are added into existing percpu stat structure, renamed
> from vlan_rx_stats to vlan_pcpu_stats.
> 
> Note : this partially reverts commit 2e59af3dcbdf (vlan: multiqueue vlan
> device)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied, although there were some conflicts since John Fastabend
made some vlan changes recently.

Please double check my work.

      parent reply	other threads:[~2010-11-16 19:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11  9:42 [PATCH net-next-2.6] vlan: lockless transmit path Eric Dumazet
2010-11-11 17:40 ` Jesse Gross
2010-11-11 17:52   ` Eric Dumazet
2010-11-11 18:56     ` Jesse Gross
2010-11-11 19:42       ` [PATCH net-next-2.6] vlan: remove ndo_select_queue() logic Eric Dumazet
2010-11-11 22:24         ` Jesse Gross
2010-11-12 15:50         ` Patrick McHardy
2010-11-16 19:24         ` David Miller
2010-11-16 19:54           ` Eric Dumazet
2010-11-17  4:12             ` John Fastabend
2010-11-16 19:24 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101116.112424.102532013.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).