From: Thomas Graf <tgraf@infradead.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Stephen Hemminger <shemminger@vyatta.com>,
NetDev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: the future of ethtool
Date: Tue, 16 Nov 2010 01:25:53 -0500 [thread overview]
Message-ID: <20101116062553.GD24292@canuck.infradead.org> (raw)
In-Reply-To: <1289866230.2586.65.camel@bwh-desktop>
On Tue, Nov 16, 2010 at 12:10:30AM +0000, Ben Hutchings wrote:
> I would expect to treat each operation in a multiple-set as conditional
> on the success of all previous operations. ethtool or other utilities
> should then take care to put operations in a sensible order (e.g. enable
> TX checksum before TSO, if those remain separate operations). Error
> reporting in the core is then as simple as reporting how many operations
> were successful plus the error code for the one that failed.
This is already not that trivial with current netlink limitations.
We are pretty much limited to a single int when returning error
states. One more reason to rethink current netlink error semantics.
next prev parent reply other threads:[~2010-11-16 6:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 19:41 the future of ethtool Jeff Garzik
2010-11-15 20:18 ` Ben Hutchings
2010-11-15 20:44 ` Stephen Hemminger
2010-11-15 21:14 ` Ben Hutchings
2010-11-15 21:14 ` Stephen Hemminger
2010-11-15 21:52 ` Ben Hutchings
2010-11-15 22:49 ` Jeff Garzik
2010-11-15 23:33 ` Thomas Graf
2010-11-16 0:07 ` Jeff Garzik
2010-11-16 0:10 ` Ben Hutchings
2010-11-16 6:25 ` Thomas Graf [this message]
2010-11-16 2:02 ` David Miller
2010-11-16 6:17 ` Thomas Graf
2010-11-15 21:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116062553.GD24292@canuck.infradead.org \
--to=tgraf@infradead.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).