From: David Miller <davem@davemloft.net>
To: Sarveshwar.Bandi@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-2.6 PATCH] be2net: Fix to avoid firmware update when interface is not open.
Date: Thu, 18 Nov 2010 09:26:03 -0800 (PST) [thread overview]
Message-ID: <20101118.092603.104065601.davem@davemloft.net> (raw)
In-Reply-To: <20101118140755.GA9686@emulex.com>
From: Sarveshwar Bandi <Sarveshwar.Bandi@emulex.com>
Date: Thu, 18 Nov 2010 19:37:56 +0530
> Since interrupts are enabled only when open is called on the interface,
> Attempting a firmware update operation when interface is down could lead to
> partial success or failure of operation. This fix fails the request if
> netif_running is false.
>
> Signed-off-by: Sarveshwar Bandi <Sarveshwar.Bandi@emulex.com>
These status values you are returning from be_load_fw() go all
the way back to userspace.
Therefore "-1" is not appropriate, and instead you should return
real negative errno error values such as -EINVAL, -ENODEV, and
the like.
Please fix this up and resubmit your patch.
Thank you.
next prev parent reply other threads:[~2010-11-18 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 14:07 [net-2.6 PATCH] be2net: Fix to avoid firmware update when interface is not open Sarveshwar Bandi
2010-11-18 17:26 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-19 9:44 Sarveshwar Bandi
2010-11-19 17:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118.092603.104065601.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Sarveshwar.Bandi@emulex.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).