From: David Miller <davem@davemloft.net>
To: w.sang@pengutronix.de
Cc: netdev@vger.kernel.org, sameo@linux.intel.com
Subject: Re: [PATCH] net: irda: irttp: sync error paths of data- and udata-requests
Date: Thu, 18 Nov 2010 12:24:51 -0800 (PST) [thread overview]
Message-ID: <20101118.122451.191398084.davem@davemloft.net> (raw)
In-Reply-To: <1289936402-25277-1-git-send-email-w.sang@pengutronix.de>
From: Wolfram Sang <w.sang@pengutronix.de>
Date: Tue, 16 Nov 2010 20:40:02 +0100
> irttp_data_request() returns meaningful errorcodes, while irttp_udata_request()
> just returns -1 in similar situations. Sync the two and the loglevels of the
> accompanying output.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: David Miller <davem@davemloft.net>
> ---
>
> Thank you David for picking up the zero-byte-packet-patch. Now as it was
> applied, this one might be interesting, too (on top of it)? Nothing seriously
> needed, but looks more proper IMHO. LXR says that are callers of these
> functions check with < 0 anyhow.
Better error code reporting is always appreciated :-)
Applied, thanks.
prev parent reply other threads:[~2010-11-18 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 23:19 [RFC] irda: irttp: allow zero byte packets Wolfram Sang
2010-11-16 17:51 ` David Miller
2010-11-16 19:40 ` [PATCH] net: irda: irttp: sync error paths of data- and udata-requests Wolfram Sang
2010-11-18 20:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118.122451.191398084.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).