From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: David Miller <davem@davemloft.net>
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: net-next-2.6 [PATCH 0/6]: dccp ccid-2: Ack Vector patch set second/concluding part II
Date: Thu, 18 Nov 2010 07:42:00 +0100 [thread overview]
Message-ID: <20101118064200.GA5457@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <20101115.110459.68121782.davem@davemloft.net>
> Some of the new functions you added had some coding style quirks,
> for example the openning brace for dccp_ackvec_clear_state()
> has an unnecessary space before it on that line.
>
> Please fix those sorts of things up, thanks.
I am sorry, this glitch must have occurred since I last ran checkpatch.pl.
Please find a fix attached. I have checked all patches again, line-by-line
and using checkpatch.pl. I found only this one occurrence, checking twice.
It is also on top today's copy of net-next-2.6, on
git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
(I tried to put up the patches on top of this, but this did not work cleanly,
due to inter-dependencies. I apologize for this.)
>>>>>>>>>>>>>>>>>>>>>>>>>> Patch <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
dccp ccid-2: whitespace fix-up
This fixes whitespace noise introduced in commit "dccp ccid-2: Algorithm to
update buffer state", 5753fdfe8bd8e9a2ff9e5af19b0ffc78bfcd502a, 14 Nov 2010.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
ackvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/dccp/ackvec.c
+++ b/net/dccp/ackvec.c
@@ -282,7 +282,7 @@ void dccp_ackvec_input(struct dccp_ackvec *av, struct sk_buff *skb)
* packet of group (2) in 11.4.2.
*/
void dccp_ackvec_clear_state(struct dccp_ackvec *av, const u64 ackno)
- {
+{
struct dccp_ackvec_record *avr, *next;
u8 runlen_now, eff_runlen;
s64 delta;
next prev parent reply other threads:[~2010-11-18 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dccp_ccid2_ack_vector_patch_set_concluding_part_II>
2010-11-15 6:29 ` net-next-2.6 [PATCH 0/6]: dccp ccid-2: Ack Vector patch set second/concluding part II Gerrit Renker
2010-11-15 6:29 ` [PATCH 1/6] dccp ccid-2: Algorithm to update buffer state Gerrit Renker
2010-11-15 6:29 ` [PATCH 2/6] dccp ccid-2: Update code for the Ack Vector input/registration routine Gerrit Renker
2010-11-15 6:29 ` [PATCH 3/6] dccp ccid-2: Consolidate Ack-Vector processing within main DCCP module Gerrit Renker
2010-11-15 6:29 ` [PATCH 4/6] dccp ccid-2: Schedule Sync as out-of-band mechanism Gerrit Renker
2010-11-15 6:29 ` [PATCH 5/6] dccp ccid-2: Remove old infrastructure Gerrit Renker
2010-11-15 6:29 ` [PATCH 6/6] dccp ccid-2: Separate option parsing from CCID processing Gerrit Renker
2010-11-15 19:04 ` net-next-2.6 [PATCH 0/6]: dccp ccid-2: Ack Vector patch set second/concluding part II David Miller
2010-11-18 6:42 ` Gerrit Renker [this message]
2010-11-18 17:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118064200.GA5457@gerrit.erg.abdn.ac.uk \
--to=gerrit@erg.abdn.ac.uk \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).