From: David Miller <davem@davemloft.net>
To: jonas@southpole.se
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] ethoc: Double check pending RX packet
Date: Wed, 24 Nov 2010 11:37:14 -0800 (PST) [thread overview]
Message-ID: <20101124.113714.232765158.davem@davemloft.net> (raw)
In-Reply-To: <1290606058-26703-6-git-send-email-jonas@southpole.se>
From: Jonas Bonn <jonas@southpole.se>
Date: Wed, 24 Nov 2010 14:40:55 +0100
> An interrupt may occur between checking bd.stat and clearing the
> interrupt source register which would result in the packet going totally
> unnoticed as the interrupt will be missed. Double check bd.stat after
> clearing the interrupt source register to guard against such an
> occurrence.
>
> Signed-off-by: Jonas Bonn <jonas@southpole.se>
...
> + if (bd.stat & RX_BD_EMPTY)
Trailing whitespace.
> + break;
> +
> + }
Unnecessary empty line.
next prev parent reply other threads:[~2010-11-24 19:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:40 ethoc driver updates Jonas Bonn
2010-11-24 13:40 ` [PATCH 1/8] ethoc: Add device tree configuration Jonas Bonn
2010-11-24 19:35 ` David Miller
2010-11-24 13:40 ` [PATCH 2/8] ethoc: remove unused spinlock Jonas Bonn
2010-11-24 13:40 ` [PATCH 3/8] ethoc: enable interrupts after napi_complete Jonas Bonn
2010-11-24 18:45 ` Laurent Chavey
[not found] ` <AANLkTim=Y6NGk8MSq=hJTrBKaYuk4SJ_7wA=f+UBy3d0@mail.gmail.com>
2010-11-24 19:33 ` Laurent Chavey
2010-11-24 13:40 ` [PATCH 4/8] ethoc: prevent overflow of rx counter Jonas Bonn
2010-11-24 16:30 ` Ben Hutchings
2010-11-24 17:34 ` Eric Dumazet
2010-11-24 19:36 ` David Miller
2010-11-24 13:40 ` [PATCH 5/8] ethoc: Double check pending RX packet Jonas Bonn
2010-11-24 19:37 ` David Miller [this message]
2010-11-24 13:40 ` [PATCH 6/8] ethoc: rework interrupt handling Jonas Bonn
2010-11-24 19:38 ` David Miller
2010-11-24 13:40 ` [PATCH 7/8] ethoc: rework mdio read/write Jonas Bonn
2010-11-24 13:40 ` [PATCH 8/8] ethoc: fix function return type Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124.113714.232765158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jonas@southpole.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).