netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Shannon Wynter <shannonw@jumbolotteries.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
	netdev@vger.kernel.org
Subject: Re: DMA Quirks for skge.c
Date: Fri, 26 Nov 2010 10:21:02 +0100	[thread overview]
Message-ID: <20101126092059.GA2628@redhat.com> (raw)
In-Reply-To: <4CEF565A.6060803@jumbolotteries.com>

Hi

(cc Stephen and netdev)

On Fri, Nov 26, 2010 at 04:40:26PM +1000, Shannon Wynter wrote:
> Hi there.
> 
> I truly thank you for resolving the problem with the Gigabyte board
> as without your fix I never would have been able to pinpoint the
> issue I was having with my network card after upgrading my memory.
> 
> I submit to you a patch that adds the ASUS A8N-SLI Premium board to
> the list of poorly built boards.
> 
> I do wonder if it might be an idea to also add a module parameter
> that forces 32 bit.

Maybe for debug purposes it will be useful, but I dislike situation when
users have to use module options to make hardware work. Anyway Stephen
said that he works on better solution for that problem ... 

> Kind regards
> 
> Shannon

> diff -uNr linux-2.6.37-rc3.old/drivers/net/skge.c linux-2.6.37-rc3.new//drivers/net/skge.c
> --- linux-2.6.37-rc3.old/drivers/net/skge.c	2010-11-26 08:35:21.000000000 +1000
> +++ linux-2.6.37-rc3.new//drivers/net/skge.c	2010-11-26 08:58:52.000000000 +1000
> @@ -4158,6 +4158,13 @@
>  			DMI_MATCH(DMI_BOARD_NAME, "nForce"),
>  		},
>  	},
> +	{
> +		.ident = "ASUSTeK A8N-SLI Premium",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> +			DMI_MATCH(DMI_BOARD_NAME, "A8N-SLI Premium"),
> +		},
> +	},
>  	{}
>  };

Add Signed-off-by line and repost patch according to MAINTAINERS
file (to Stephen and netdev).

Thanks
Stanislaw

           reply	other threads:[~2010-11-26  9:21 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <4CEF565A.6060803@jumbolotteries.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101126092059.GA2628@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shannonw@jumbolotteries.com \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).