From: David Miller <davem@davemloft.net>
To: richard.rojfors@pelagicore.com
Cc: netdev@vger.kernel.org, ferringb@gmail.com
Subject: Re: [PATCH] ks8842: Fix TX cache flush issue
Date: Sun, 28 Nov 2010 10:38:14 -0800 (PST) [thread overview]
Message-ID: <20101128.103814.193728413.davem@davemloft.net> (raw)
In-Reply-To: <1290430257.13971.7.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Mon, 22 Nov 2010 13:50:57 +0100
> This patch fixes a cache sync issue found in MeeGo 1.1.
>
> It was found that bytes after the first 64 of the TX buffer was not
> flushed from the cache correctly.
>
> The patch switches out kmalloc/dma_map_single/dma_sync_single_for_device
> to dma_alloc_coherent.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Why is dma_sync_single_*() not working properly?
Maybe the length arguments are not correct? Maybe the cache flush
implementation accidently misses the last cache line when the buffer
length ends in the middle of a cache line.
Did you even check to see what the actual cause of the problem is?
I'm not applying this patch, not enough justification or explanation
in the commit message exists yet. For all we know there could be
a bug elsewhere, and that would effect other drivers too not just
ks8842.
prev parent reply other threads:[~2010-11-28 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 12:50 [PATCH] ks8842: Fix TX cache flush issue Richard Röjfors
2010-11-28 18:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128.103814.193728413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ferringb@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richard.rojfors@pelagicore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).