* [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
@ 2010-11-22 5:58 Toshiharu Okada
2010-11-28 1:41 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Toshiharu Okada @ 2010-11-22 5:58 UTC (permalink / raw)
To: Dr. David Alan Gilbert, David S. Miller
Cc: David S. Miller, Randy Dunlap, John Linn, Ralf Baechle,
Kristoffer Glembo, Maxime Bizon, Greg Rose, ML netdev, LKML,
Masayuki Ohtake, Wang, Qi, Wang, Yong Y, Andrew, Intel OTC,
Foster, Margie, Ewe, Kok Howg
The wrong of initializer entry was modified.
Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
---
drivers/net/pch_gbe/pch_gbe_param.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/pch_gbe/pch_gbe_param.c b/drivers/net/pch_gbe/pch_gbe_param.c
index 2510146..ef0996a 100644
--- a/drivers/net/pch_gbe/pch_gbe_param.c
+++ b/drivers/net/pch_gbe/pch_gbe_param.c
@@ -434,8 +434,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
.err = "using default of "
__MODULE_STRING(PCH_GBE_DEFAULT_TXD),
.def = PCH_GBE_DEFAULT_TXD,
- .arg = { .r = { .min = PCH_GBE_MIN_TXD } },
- .arg = { .r = { .max = PCH_GBE_MAX_TXD } }
+ .arg = { .r = { .min = PCH_GBE_MIN_TXD,
+ .max = PCH_GBE_MAX_TXD } }
};
struct pch_gbe_tx_ring *tx_ring = adapter->tx_ring;
tx_ring->count = TxDescriptors;
@@ -450,8 +450,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
.err = "using default of "
__MODULE_STRING(PCH_GBE_DEFAULT_RXD),
.def = PCH_GBE_DEFAULT_RXD,
- .arg = { .r = { .min = PCH_GBE_MIN_RXD } },
- .arg = { .r = { .max = PCH_GBE_MAX_RXD } }
+ .arg = { .r = { .min = PCH_GBE_MIN_RXD,
+ .max = PCH_GBE_MAX_RXD } }
};
struct pch_gbe_rx_ring *rx_ring = adapter->rx_ring;
rx_ring->count = RxDescriptors;
--
1.6.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
2010-11-22 5:58 [PATCH 2/2] pch_gbe driver: The wrong of initializer entry Toshiharu Okada
@ 2010-11-28 1:41 ` David Miller
2010-11-29 5:06 ` Toshiharu Okada
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2010-11-28 1:41 UTC (permalink / raw)
To: toshiharu-linux
Cc: linux, randy.dunlap, john.linn, ralf, kristoffer, mbizon,
gregory.v.rose, netdev, linux-kernel, masa-korg, qi.wang,
yong.y.wang, andrew.chih.howe.khor, joel.clark, margie.foster,
kok.howg.ewe
From: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Date: Mon, 22 Nov 2010 14:58:53 +0900
> The wrong of initializer entry was modified.
>
> Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
How about you give some credit to David Alan Gilbert who made
you aware of this issue?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
2010-11-28 1:41 ` David Miller
@ 2010-11-29 5:06 ` Toshiharu Okada
2010-11-29 5:59 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Toshiharu Okada @ 2010-11-29 5:06 UTC (permalink / raw)
To: David Miller
Cc: linux, randy.dunlap, john.linn, ralf, kristoffer, mbizon,
gregory.v.rose, netdev, linux-kernel, masa-korg, qi.wang,
yong.y.wang, andrew.chih.howe.khor, joel.clark, margie.foster,
kok.howg.ewe
Hi David Miller
Date: Sat, 27 Nov 2010 17:41:03 -0800 (PST)
From: "David Miller" <davem@davemloft.net>
>
> > The wrong of initializer entry was modified.
> >
> > Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
>
> How about you give some credit to David Alan Gilbert who made
> you aware of this issue?
Credit?
Does this mean that I add "Singed of by: Dr. David Alan Gilbert
<linux@trebig.org>" ?
Is my understanding correct?
Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
2010-11-29 5:06 ` Toshiharu Okada
@ 2010-11-29 5:59 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2010-11-29 5:59 UTC (permalink / raw)
To: toshiharu-linux
Cc: linux, randy.dunlap, john.linn, ralf, kristoffer, mbizon,
gregory.v.rose, netdev, linux-kernel, masa-korg, qi.wang,
yong.y.wang, andrew.chih.howe.khor, joel.clark, margie.foster,
kok.howg.ewe
From: "Toshiharu Okada" <toshiharu-linux@dsn.okisemi.com>
Date: Mon, 29 Nov 2010 14:06:23 +0900
> Hi David Miller
>
>
> Date: Sat, 27 Nov 2010 17:41:03 -0800 (PST)
> From: "David Miller" <davem@davemloft.net>
>>
>> > The wrong of initializer entry was modified.
>> >
>> > Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
>>
>> How about you give some credit to David Alan Gilbert who made
>> you aware of this issue?
>
> Credit?
> Does this mean that I add "Singed of by: Dr. David Alan Gilbert
> <linux@trebig.org>" ?
> Is my understanding correct?
You should use "Reported-by: ..."
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
@ 2010-11-29 16:18 Toshiharu Okada
2010-11-29 16:52 ` David Miller
2010-11-29 18:32 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 7+ messages in thread
From: Toshiharu Okada @ 2010-11-29 16:18 UTC (permalink / raw)
To: Dr. David Alan Gilbert, David S. Miller
Cc: David S. Miller, Randy Dunlap, John Linn, Ralf Baechle,
Kristoffer Glembo, Maxime Bizon, Greg Rose, ML netdev, LKML,
Wang, Qi, Wang, Yong Y, Andrew, Intel OTC, Foster, Margie,
Ewe, Kok Howg
The wrong of initializer entry was modified.
Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/net/pch_gbe/pch_gbe_param.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/pch_gbe/pch_gbe_param.c b/drivers/net/pch_gbe/pch_gbe_param.c
index 2510146..ef0996a 100644
--- a/drivers/net/pch_gbe/pch_gbe_param.c
+++ b/drivers/net/pch_gbe/pch_gbe_param.c
@@ -434,8 +434,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
.err = "using default of "
__MODULE_STRING(PCH_GBE_DEFAULT_TXD),
.def = PCH_GBE_DEFAULT_TXD,
- .arg = { .r = { .min = PCH_GBE_MIN_TXD } },
- .arg = { .r = { .max = PCH_GBE_MAX_TXD } }
+ .arg = { .r = { .min = PCH_GBE_MIN_TXD,
+ .max = PCH_GBE_MAX_TXD } }
};
struct pch_gbe_tx_ring *tx_ring = adapter->tx_ring;
tx_ring->count = TxDescriptors;
@@ -450,8 +450,8 @@ void pch_gbe_check_options(struct pch_gbe_adapter *adapter)
.err = "using default of "
__MODULE_STRING(PCH_GBE_DEFAULT_RXD),
.def = PCH_GBE_DEFAULT_RXD,
- .arg = { .r = { .min = PCH_GBE_MIN_RXD } },
- .arg = { .r = { .max = PCH_GBE_MAX_RXD } }
+ .arg = { .r = { .min = PCH_GBE_MIN_RXD,
+ .max = PCH_GBE_MAX_RXD } }
};
struct pch_gbe_rx_ring *rx_ring = adapter->rx_ring;
rx_ring->count = RxDescriptors;
-- 1.6.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
2010-11-29 16:18 Toshiharu Okada
@ 2010-11-29 16:52 ` David Miller
2010-11-29 18:32 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2010-11-29 16:52 UTC (permalink / raw)
To: toshiharu-linux
Cc: linux, randy.dunlap, john.linn, ralf, kristoffer, mbizon,
gregory.v.rose, netdev, linux-kernel, qi.wang, yong.y.wang,
andrew.chih.howe.khor, joel.clark, margie.foster, kok.howg.ewe
From: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Date: Tue, 30 Nov 2010 01:18:07 +0900
> The wrong of initializer entry was modified.
>
> Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
> Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] pch_gbe driver: The wrong of initializer entry
2010-11-29 16:18 Toshiharu Okada
2010-11-29 16:52 ` David Miller
@ 2010-11-29 18:32 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2010-11-29 18:32 UTC (permalink / raw)
To: Toshiharu Okada
Cc: David S. Miller, Randy Dunlap, John Linn, Ralf Baechle,
Kristoffer Glembo, Maxime Bizon, Greg Rose, ML netdev, LKML,
Wang, Qi, Wang, Yong Y, Andrew, Intel OTC, Foster, Margie,
Ewe, Kok Howg
* Toshiharu Okada (toshiharu-linux@dsn.okisemi.com) wrote:
> The wrong of initializer entry was modified.
>
> Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
> Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
Thanks.
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-11-29 18:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-22 5:58 [PATCH 2/2] pch_gbe driver: The wrong of initializer entry Toshiharu Okada
2010-11-28 1:41 ` David Miller
2010-11-29 5:06 ` Toshiharu Okada
2010-11-29 5:59 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-11-29 16:18 Toshiharu Okada
2010-11-29 16:52 ` David Miller
2010-11-29 18:32 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).