From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>, Tejun Heo <tj@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] kthread: NUMA aware kthread_create_on_cpu()
Date: Mon, 29 Nov 2010 00:01:47 +0100 [thread overview]
Message-ID: <20101128230146.GB12300@basil.fritz.box> (raw)
In-Reply-To: <1290984712.29196.100.camel@edumazet-laptop>
On Sun, Nov 28, 2010 at 11:51:51PM +0100, Eric Dumazet wrote:
> > Also this messes up the policy of the caller process. You really
> > need to save/restore it.
>
> Well, caller process duty is to create kthreads in a loop.
In this case any other allocations it may do are still on those
nodes.
> > Problem is that this ends up in architecture specific code
> > for the stack, so may be a larger patch.
>
> I suggest arches that need slab to allocate kthread stacks do the
> appropriate changes, because I am not able to make them myself.
>
> On x86, we use page allocator only, so NUMA mempolicy is used.
task_struct is always allocated from slab.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-11-28 23:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 19:33 [PATCH] kthread: NUMA aware kthread_create_on_cpu() Eric Dumazet
2010-11-28 22:40 ` Andi Kleen
2010-11-28 22:51 ` Eric Dumazet
2010-11-28 23:01 ` Andi Kleen [this message]
2010-11-28 23:37 ` Eric Dumazet
2010-11-29 9:05 ` Andi Kleen
2010-11-29 9:38 ` Eric Dumazet
2010-11-29 15:13 ` [PATCH v2 0/4] " Eric Dumazet
2010-11-29 16:09 ` Andi Kleen
2010-11-29 17:39 ` David Miller
2010-11-29 17:59 ` Eric Dumazet
2010-11-29 23:31 ` Rusty Russell
2010-11-29 15:13 ` [PATCH v2 1/4] mm: NUMA aware alloc_task_struct_node() Eric Dumazet
2010-11-29 15:14 ` [PATCH v2 2/4] mm: NUMA aware alloc_thread_info_node() Eric Dumazet
2010-11-29 15:14 ` [PATCH v2 3/4] kthread: NUMA aware kthread_create_on_cpu() Eric Dumazet
2010-12-10 0:44 ` Andrew Morton
2010-12-10 5:59 ` Eric Dumazet
2010-12-10 6:32 ` Andrew Morton
2010-12-10 7:02 ` Eric Dumazet
2010-12-10 7:09 ` Andrew Morton
2010-12-13 6:26 ` Thomas Fjellstrom
2010-11-29 15:15 ` [PATCH v2 4/4] kthread: use kthread_create_on_cpu() Eric Dumazet
2010-11-29 15:19 ` Tejun Heo
2010-11-30 9:38 ` David Howells
2010-11-30 9:59 ` Eric Dumazet
2010-11-29 9:03 ` [PATCH] kthread: NUMA aware kthread_create_on_cpu() Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128230146.GB12300@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).