netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: dshwatrz@gmail.com, netdev@vger.kernel.org
Subject: Re: [net-next-2.6] XFRM: remove unused member in xfrm_encap_tmpl.
Date: Mon, 29 Nov 2010 10:57:38 -0800 (PST)	[thread overview]
Message-ID: <20101129.105738.59675582.davem@davemloft.net> (raw)
In-Reply-To: <4CF3EBF2.5060308@iki.fi>

From: Timo Teräs <timo.teras@iki.fi>
Date: Mon, 29 Nov 2010 20:07:46 +0200

> On 01/-10/-28163 09:59 PM, David Shwatrz wrote:
>> Hi,
>>  The patch removes unused member in xfrm_encap_tmpl.
>> 
>> Regards,
>> David Shwartz
>> 
>> 
>> Signed-off-by: David Shwartz <dshwatrz@gmail.com>
>> 
>> 
>> diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
>> index b971e38..7312707 100644
>> --- a/include/linux/xfrm.h
>> +++ b/include/linux/xfrm.h
>> @@ -235,7 +235,6 @@ struct xfrm_encap_tmpl {
>>  	__u16		encap_type;
>>  	__be16		encap_sport;
>>  	__be16		encap_dport;
>> -	xfrm_address_t	encap_oa;
>>  };
>>  
>>  /* AEVENT flags  */
> 
> struct xfrm_encap_tmpl is exposed to userland via netlink. This would
> break ABI.

RIght.

  reply	other threads:[~2010-11-29 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-27 17:24 [PATCH net-next-2.6] XFRM: remove unused member in xfrm_encap_tmpl David Shwatrz
2010-11-29 18:07 ` [net-next-2.6] " Timo Teräs
2010-11-29 18:57   ` David Miller [this message]
2010-11-29 19:15   ` David Shwatrz
2010-11-29 19:27     ` Timo Teräs
2010-11-29 20:09       ` David Shwatrz
2010-11-29 20:35         ` Timo Teräs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129.105738.59675582.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dshwatrz@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=timo.teras@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).