From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
szymon@janc.net.pl, mirqus@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] forcedeth: Convert to use netdev_<level> and neatening
Date: Mon, 29 Nov 2010 11:51:57 -0800 (PST) [thread overview]
Message-ID: <20101129.115157.246510826.davem@davemloft.net> (raw)
In-Reply-To: <cover.1291051316.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 29 Nov 2010 09:41:51 -0800
> Some mild restructuring and some generally neatening.
>
> The conversions of dprintk to netdev_dbg in patches 2 and 4 are
> deleted in patch 10 as these seem to have been used only
> during initial development and are not normally compiled-in.
>
> Patch 10 may be ignored if desired.
>
> Object size is reduced ~2Kb overall.
>
> $ size drivers/net/forcedeth.o.*
> text data bss dec hex filename
> 71739 336 17176 89251 15ca3 drivers/net/forcedeth.o.new
> 73416 240 17696 91352 164d8 drivers/net/forcedeth.o.old
These look fine, applied, thanks.
prev parent reply other threads:[~2010-11-29 19:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 17:41 [PATCH 00/11] forcedeth: Convert to use netdev_<level> and neatening Joe Perches
2010-11-29 17:41 ` [PATCH 01/11] forcedeth: Change reg_delay arguments and use Joe Perches
2010-11-29 17:41 ` [PATCH 02/11] forcedeth: convert dprintk(KERN_DEBUG to netdev_dbg Joe Perches
2010-11-29 17:41 ` [PATCH 03/11] forcedeth: Use print_hex_dump Joe Perches
2010-11-29 17:41 ` [PATCH 04/11] forcedeth: Convert remaining dprintk to netdev_dbg Joe Perches
2010-11-29 17:41 ` [PATCH 05/11] forcedeth: Use pr_fmt and pr_<level> Joe Perches
2010-11-29 17:41 ` [PATCH 06/11] forcedeth: Convert pr_<level> to netdev_<level> Joe Perches
2010-11-29 17:41 ` [PATCH 07/11] forcedeth: Add function init_realtek_8211b Joe Perches
2010-11-29 17:41 ` [PATCH 08/11] forcedeth: Separate vendor specific initializations into functions Joe Perches
2010-11-29 17:42 ` [PATCH 09/11] forcedeth: Convert dev_printk(<level> to dev_<level>( Joe Perches
2010-11-29 17:42 ` [PATCH 10/11] forcedeth: Remove netdev_dbg uses Joe Perches
2010-11-29 17:42 ` [PATCH 11/11] forcedeth: Use netdev_dbg for printk(KERN_DEBUG Joe Perches
2010-11-29 19:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129.115157.246510826.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).