From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: therbert@google.com, netdev@vger.kernel.org,
bhutchings@solarflare.com, jesse.brandeburg@intel.com
Subject: Re: [PATCH net-next-2.6] sched: use xps information for qdisc NUMA affinity
Date: Tue, 30 Nov 2010 11:21:06 -0800 (PST) [thread overview]
Message-ID: <20101130.112106.183035811.davem@davemloft.net> (raw)
In-Reply-To: <1291144047.2904.224.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 30 Nov 2010 20:07:27 +0100
[ Jesse CC:'d ]
> netdev struct itself is shared by all cpus, so there is no real choice,
> unless you know one netdev will be used by a restricted set of
> cpus/nodes... Probably very unlikely in practice.
Unfortunately Jesse has found non-trivial gains by NUMA localizing the
netdev struct during routing tests in soome configurations.
> We could change (only on NUMA setups maybe)
>
> struct netdev_queue *_tx;
>
> to a
>
> struct netdev_queue **_tx;
>
> and allocate each "struct netdev_queue" on appropriate node, but adding
> one indirection level might be overkill...
>
> For very hot small structures, (one or two cache lines), I am not sure
> its worth the pain.
Jesse, do you think this would help the case you were testing?
next prev parent reply other threads:[~2010-11-30 19:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 23:17 [PATCH 2/2 v7] xps: Transmit Packet Steering Tom Herbert
2010-11-22 11:42 ` Changli Gao
2010-11-22 13:33 ` Eric Dumazet
2010-11-24 19:45 ` David Miller
2010-11-26 17:13 ` Tom Herbert
2010-11-26 17:17 ` Eric Dumazet
2010-11-28 15:43 ` [PATCH net-next-2.6] xps: NUMA allocations for per cpu data Eric Dumazet
2010-11-29 17:43 ` David Miller
2010-11-25 17:12 ` [PATCH 2/2 v7] xps: Transmit Packet Steering Ben Hutchings
2010-11-29 18:14 ` [PATCH net-next-2.6] sched: use xps information for qdisc NUMA affinity Eric Dumazet
2010-11-30 18:31 ` Tom Herbert
2010-11-30 18:39 ` Eric Dumazet
2010-11-30 18:46 ` Ben Hutchings
2010-11-30 18:52 ` Eric Dumazet
2010-11-30 18:48 ` David Miller
2010-11-30 19:07 ` Eric Dumazet
2010-11-30 19:19 ` Ben Hutchings
2010-11-30 19:21 ` David Miller [this message]
2010-11-30 20:01 ` Brandeburg, Jesse
2010-12-01 20:49 ` David Miller
2010-12-01 20:55 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130.112106.183035811.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).