From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 3/3] ipip: add module alias for tunl0 tunnel device Date: Tue, 30 Nov 2010 08:08:42 -0800 Message-ID: <20101130080842.685e0b70@nehalam> References: <20101129194746.724222156@vyatta.com> <20101129194805.851988995@vyatta.com> <1291101577.2725.41.camel@edumazet-laptop> <1291105269.2725.52.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Changli Gao , David Miller , netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail.vyatta.com ([76.74.103.46]:44436 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782Ab0K3QIp convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2010 11:08:45 -0500 In-Reply-To: <1291105269.2725.52.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 30 Nov 2010 09:21:09 +0100 Eric Dumazet wrote: > Le mardi 30 novembre 2010 =E0 15:55 +0800, Changli Gao a =E9crit : > > On Tue, Nov 30, 2010 at 3:19 PM, Eric Dumazet wrote: > > > Le lundi 29 novembre 2010 =E0 11:47 -0800, Stephen Hemminger a =E9= crit : > > >> pi=E8ce jointe document texte brut (ipip-alias.patch) > > >> If ipip is built as a module the 'ip tunnel add' command would f= ail because > > >> the ipip module was not being autoloaded. Adding an alias for > > >> the tunl0 device name cause dev_load() to autoload it when neede= d. > > >> > > >> Signed-off-by: Stephen Hemminger > > >> > > >> --- a/net/ipv4/ipip.c 2010-11-29 11:40:25.026277890 -0800 > > >> +++ b/net/ipv4/ipip.c 2010-11-29 11:41:05.790681069 -0800 > > >> @@ -913,3 +913,4 @@ static void __exit ipip_fini(void) > > >> module_init(ipip_init); > > >> module_exit(ipip_fini); > > >> MODULE_LICENSE("GPL"); > > >> +MODULE_ALIAS("tunl0"); > > > > > > I am not sure I understand you... > > > > > > Here, I do have ipip built as a module, and I have no problem : > > > > > > # lsmod|grep ipip > > > # ip tunnel add > > > cannot determine tunnel mode (ipip, gre or sit) > > > # lsmod|grep ipip > > > # ip tunnel add mode ipip > > > # lsmod|grep ipip > > > ipip 7692 0 > > > tunnel4 2949 1 ipip > > > # > > > > > > What am I missing ? > > > > > > > >=20 > > localhost linux # lsmod > > Module Size Used by > > ipv6 309359 12 > > localhost linux # ip -V > > ip utility, iproute2-ss091226 > > localhost linux # ip tunnel add mode gre > > ioctl: No such device > > localhost linux # ip tunnel add mode ipip > > ioctl: No such device > > localhost linux # modprobe ip_gre > > localhost linux # modprobe ipip > > localhost linux # ip tunnel add mode ipip > > localhost linux # ip tunnel add mode gre > > localhost linux # lsmod > > Module Size Used by > > ipip 8128 0 > > tunnel4 2683 1 ipip > > ip_gre 15055 0 > > gre 1967 1 ip_gre > > ipv6 309359 13 ip_gre > >=20 > >=20 >=20 > Hmm. I still dont get it, ipv6 as a module ? >=20 > Works well here. >=20 > # lsmod > Module Size Used by > bonding 89194 0=20 > ipv6 232889 29 bonding > # ip tunnel add mode ipip > # lsmod > Module Size Used by > ipip 6221 0=20 > bonding 89194 0=20 > ipv6 232889 29 bonding > # ip -V > ip utility, iproute2-ss100823 > #=20 If you run debian there is a list of aliases in /etc/modprobe.d/aliases= =2Econf that includes the ipip alias. My patch provides same information from the kernel. In olden times, the kernel relied more on user space defined aliases, but in the modern era MODULE_ALIAS() is used to provide that information.