From: David Miller <davem@davemloft.net>
To: hauke@hauke-m.de
Cc: zambrano@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] b44: fix workarround for wap54g10
Date: Wed, 01 Dec 2010 11:12:28 -0800 (PST) [thread overview]
Message-ID: <20101201.111228.102548986.davem@davemloft.net> (raw)
In-Reply-To: <1290876463-4372-1-git-send-email-hauke@hauke-m.de>
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Sat, 27 Nov 2010 17:47:43 +0100
> The code for the b44_wap54g10_workaround was never included, because
> the config option was wrong. The nvram_get function was never in
> mainline kernel, only in external OpenWrt patches.
>
> The code should be compiled in when CONFIG_BCM47XX is selected and not
> when CONFIG_SSB_DRIVER_MIPS is selected, because nvram_getenv is only
> available on bcm47xx platforms and now in the mainline kernel code.
> Using an include is better than a second function declaration, to fix
> this when the function signature changes.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Applied, thank you.
prev parent reply other threads:[~2010-12-01 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 16:47 [PATCH] b44: fix workarround for wap54g10 Hauke Mehrtens
2010-12-01 19:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201.111228.102548986.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox