* [PATCH 1/3] vxge: remove unnecessary printks
@ 2010-11-30 4:02 Jon Mason
2010-11-30 4:02 ` [PATCH 2/3] vxge: use strcpy for strings Jon Mason
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jon Mason @ 2010-11-30 4:02 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Sivakumar Subramani, Sreenivasa Honnur, Ram Vepa
Remove printks for ring blocks, fifo blocks, and rx doorbell mode as
they clutter the dmesg output during modprobe and provide no useful
information.
Signed-off-by: Jon Mason <jon.mason@exar.com>
---
drivers/net/vxge/vxge-main.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index a21dae1..44129c3 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -3922,9 +3922,6 @@ static void __devinit vxge_print_parm(struct vxgedev *vdev, u64 vpath_mask)
vxge_debug_init(VXGE_TRACE,
"%s: MAC Address learning enabled", vdev->ndev->name);
- vxge_debug_init(VXGE_TRACE,
- "%s: Rx doorbell mode enabled", vdev->ndev->name);
-
for (i = 0; i < VXGE_HW_MAX_VIRTUAL_PATHS; i++) {
if (!vxge_bVALn(vpath_mask, i, 1))
continue;
@@ -3937,14 +3934,6 @@ static void __devinit vxge_print_parm(struct vxgedev *vdev, u64 vpath_mask)
((struct __vxge_hw_device *)(vdev->devh))->
config.vp_config[i].rpa_strip_vlan_tag
? "Enabled" : "Disabled");
- vxge_debug_init(VXGE_TRACE,
- "%s: Ring blocks : %d", vdev->ndev->name,
- ((struct __vxge_hw_device *)(vdev->devh))->
- config.vp_config[i].ring.ring_blocks);
- vxge_debug_init(VXGE_TRACE,
- "%s: Fifo blocks : %d", vdev->ndev->name,
- ((struct __vxge_hw_device *)(vdev->devh))->
- config.vp_config[i].fifo.fifo_blocks);
vxge_debug_ll_config(VXGE_TRACE,
"%s: Max frags : %d", vdev->ndev->name,
((struct __vxge_hw_device *)(vdev->devh))->
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] vxge: use strcpy for strings
2010-11-30 4:02 [PATCH 1/3] vxge: remove unnecessary printks Jon Mason
@ 2010-11-30 4:02 ` Jon Mason
2010-12-01 21:02 ` David Miller
2010-11-30 4:02 ` [PATCH 3/3] vxge: update driver version Jon Mason
2010-12-01 21:02 ` [PATCH 1/3] vxge: remove unnecessary printks David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Jon Mason @ 2010-11-30 4:02 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Sivakumar Subramani, Sreenivasa Honnur, Ram Vepa
Use strncpy instead of memcpy when working on strings
Signed-off-by: Jon Mason <jon.mason@exar.com>
---
drivers/net/vxge/vxge-main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 44129c3..8a84152 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -3451,7 +3451,7 @@ static void vxge_device_unregister(struct __vxge_hw_device *hldev)
vxge_debug_entryexit(vdev->level_trace, "%s: %s:%d", vdev->ndev->name,
__func__, __LINE__);
- memcpy(buf, dev->name, IFNAMSIZ);
+ strncpy(buf, dev->name, IFNAMSIZ);
/* in 2.6 will call stop() if device is up */
unregister_netdev(dev);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] vxge: update driver version
2010-11-30 4:02 [PATCH 1/3] vxge: remove unnecessary printks Jon Mason
2010-11-30 4:02 ` [PATCH 2/3] vxge: use strcpy for strings Jon Mason
@ 2010-11-30 4:02 ` Jon Mason
2010-12-01 21:02 ` David Miller
2010-12-01 21:02 ` [PATCH 1/3] vxge: remove unnecessary printks David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Jon Mason @ 2010-11-30 4:02 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Sivakumar Subramani, Sreenivasa Honnur, Ram Vepa
Update vxge driver version
Signed-off-by: Jon Mason <jon.mason@exar.com>
---
drivers/net/vxge/vxge-version.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxge/vxge-version.h b/drivers/net/vxge/vxge-version.h
index f05bb2f..9c93e0a 100644
--- a/drivers/net/vxge/vxge-version.h
+++ b/drivers/net/vxge/vxge-version.h
@@ -16,8 +16,8 @@
#define VXGE_VERSION_MAJOR "2"
#define VXGE_VERSION_MINOR "0"
-#define VXGE_VERSION_FIX "10"
-#define VXGE_VERSION_BUILD "21808"
+#define VXGE_VERSION_FIX "11"
+#define VXGE_VERSION_BUILD "21932"
#define VXGE_VERSION_FOR "k"
#define VXGE_FW_VER(maj, min, bld) (((maj) << 16) + ((min) << 8) + (bld))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] vxge: remove unnecessary printks
2010-11-30 4:02 [PATCH 1/3] vxge: remove unnecessary printks Jon Mason
2010-11-30 4:02 ` [PATCH 2/3] vxge: use strcpy for strings Jon Mason
2010-11-30 4:02 ` [PATCH 3/3] vxge: update driver version Jon Mason
@ 2010-12-01 21:02 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-12-01 21:02 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, sivakumar.subramani, sreenivasa.honnur, ram.vepa
From: Jon Mason <jon.mason@exar.com>
Date: Mon, 29 Nov 2010 22:02:45 -0600
> Remove printks for ring blocks, fifo blocks, and rx doorbell mode as
> they clutter the dmesg output during modprobe and provide no useful
> information.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-01 21:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-30 4:02 [PATCH 1/3] vxge: remove unnecessary printks Jon Mason
2010-11-30 4:02 ` [PATCH 2/3] vxge: use strcpy for strings Jon Mason
2010-12-01 21:02 ` David Miller
2010-11-30 4:02 ` [PATCH 3/3] vxge: update driver version Jon Mason
2010-12-01 21:02 ` David Miller
2010-12-01 21:02 ` [PATCH 1/3] vxge: remove unnecessary printks David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).