From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: david_mccullough@mcafee.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net/ipv6/sit.c: return unhandled skb to tunnel4_rcv
Date: Wed, 01 Dec 2010 13:19:55 -0800 (PST) [thread overview]
Message-ID: <20101201.131955.68134278.davem@davemloft.net> (raw)
In-Reply-To: <1291097564.2725.15.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 30 Nov 2010 07:12:44 +0100
> Le mardi 30 novembre 2010 à 15:32 +1000, David McCullough a écrit :
>> Hi all,
>>
>> I found a problem using an IPv6 over IPv4 tunnel. When CONFIG_IPV6_SIT
>> was enabled, the packets would be rejected as net/ipv6/sit.c was catching
>> all IPPROTO_IPV6 packets and returning an ICMP port unreachable error.
>>
>> I think this patch fixes the problem cleanly. I believe the code in
>> net/ipv4/tunnel4.c:tunnel4_rcv takes care of it properly if none of the
>> handlers claim the skb.
>>
>> Patch is against 2.6.35, bit still applies to current.
>>
>> Cheers,
>> Davidm
>>
>> Signed-off-by: David McCullough <david_mccullough@mcafee.com>
...
> Good catch !
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2010-12-01 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 5:32 [PATCH] net/ipv6/sit.c: return unhandled skb to tunnel4_rcv David McCullough
2010-11-30 6:12 ` Eric Dumazet
2010-12-01 21:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201.131955.68134278.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david_mccullough@mcafee.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).