Re: [PATCH v2] add netdev led trigger

Re: [PATCH v2] add netdev led trigger

[Andi Kleen]

Eric Cooper <ecc@cmu.edu> writes:

> Add a netdev LED trigger for all Blinkenlights lovers...
> Originally taken from https://dev.openwrt.org/ticket/2776
> Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
> and for 2.6.36 by Eric Cooper <ecc@cmu.edu>

You should really send this to netdev too.

Some comments:

The timer seems power unfriendly -- it will always tick even if nothing 
happens.

Using the device name as an identifier is not reliable, they may 
not be unique.

rwlocks are deprecated.

your store code has a off by one I think, it's possible to put 
not 0 terminated data in the string.


-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

Re: [PATCH v2] add netdev led trigger

[Eric Cooper]

On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andi Kleen wrote:
> Using the device name as an identifier is not reliable, they may not
> be unique.

I'm confused about this -- how else can the user specify the desired network
interface?

> rwlocks are deprecated.

In favor of what?  Should I use a spinlock?

Thanks for the feedback.

-- 
Eric Cooper             e c c @ c m u . e d u

Re: [PATCH v2] add netdev led trigger

[Andi Kleen]

On Tue, Nov 30, 2010 at 07:03:00PM -0500, Eric Cooper wrote:
> On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andi Kleen wrote:
> > Using the device name as an identifier is not reliable, they may not
> > be unique.
> 
> I'm confused about this -- how else can the user specify the desired network
> interface?

For presenting the user the name is probably still the best, but internally
better use the interface index.
> 
> > rwlocks are deprecated.
> 
> In favor of what?  Should I use a spinlock?

spinlocks or mutexes.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.