* Re: [PATCH v2] add netdev led trigger [not found] <1290998056-8310-1-git-send-email-ecc@cmu.edu> @ 2010-11-29 10:15 ` Andi Kleen 2010-12-01 0:03 ` Eric Cooper 0 siblings, 1 reply; 3+ messages in thread From: Andi Kleen @ 2010-11-29 10:15 UTC (permalink / raw) To: Eric Cooper; +Cc: linux-kernel, linux-doc, Richard Purdie, Randy Dunlap, netdev Eric Cooper <ecc@cmu.edu> writes: > Add a netdev LED trigger for all Blinkenlights lovers... > Originally taken from https://dev.openwrt.org/ticket/2776 > Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org> > and for 2.6.36 by Eric Cooper <ecc@cmu.edu> You should really send this to netdev too. Some comments: The timer seems power unfriendly -- it will always tick even if nothing happens. Using the device name as an identifier is not reliable, they may not be unique. rwlocks are deprecated. your store code has a off by one I think, it's possible to put not 0 terminated data in the string. -Andi -- ak@linux.intel.com -- Speaking for myself only. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] add netdev led trigger 2010-11-29 10:15 ` [PATCH v2] add netdev led trigger Andi Kleen @ 2010-12-01 0:03 ` Eric Cooper 2010-12-01 14:03 ` Andi Kleen 0 siblings, 1 reply; 3+ messages in thread From: Eric Cooper @ 2010-12-01 0:03 UTC (permalink / raw) To: Andi Kleen; +Cc: linux-kernel, linux-doc, Richard Purdie, Randy Dunlap, netdev On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andi Kleen wrote: > Using the device name as an identifier is not reliable, they may not > be unique. I'm confused about this -- how else can the user specify the desired network interface? > rwlocks are deprecated. In favor of what? Should I use a spinlock? Thanks for the feedback. -- Eric Cooper e c c @ c m u . e d u ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] add netdev led trigger 2010-12-01 0:03 ` Eric Cooper @ 2010-12-01 14:03 ` Andi Kleen 0 siblings, 0 replies; 3+ messages in thread From: Andi Kleen @ 2010-12-01 14:03 UTC (permalink / raw) To: Andi Kleen, linux-kernel, linux-doc, Richard Purdie, Randy Dunlap, netdev On Tue, Nov 30, 2010 at 07:03:00PM -0500, Eric Cooper wrote: > On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andi Kleen wrote: > > Using the device name as an identifier is not reliable, they may not > > be unique. > > I'm confused about this -- how else can the user specify the desired network > interface? For presenting the user the name is probably still the best, but internally better use the interface index. > > > rwlocks are deprecated. > > In favor of what? Should I use a spinlock? spinlocks or mutexes. -Andi -- ak@linux.intel.com -- Speaking for myself only. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-01 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1290998056-8310-1-git-send-email-ecc@cmu.edu>
2010-11-29 10:15 ` [PATCH v2] add netdev led trigger Andi Kleen
2010-12-01 0:03 ` Eric Cooper
2010-12-01 14:03 ` Andi Kleen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).