From: Andi Kleen <andi@firstfloor.org>
To: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>,
Randy Dunlap <rdunlap@xenotime.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] add netdev led trigger
Date: Wed, 1 Dec 2010 15:03:30 +0100 [thread overview]
Message-ID: <20101201140330.GA7218@basil.fritz.box> (raw)
In-Reply-To: <20101201000300.GJ21496@localhost>
On Tue, Nov 30, 2010 at 07:03:00PM -0500, Eric Cooper wrote:
> On Mon, Nov 29, 2010 at 11:15:51AM +0100, Andi Kleen wrote:
> > Using the device name as an identifier is not reliable, they may not
> > be unique.
>
> I'm confused about this -- how else can the user specify the desired network
> interface?
For presenting the user the name is probably still the best, but internally
better use the interface index.
>
> > rwlocks are deprecated.
>
> In favor of what? Should I use a spinlock?
spinlocks or mutexes.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2010-12-01 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1290998056-8310-1-git-send-email-ecc@cmu.edu>
2010-11-29 10:15 ` [PATCH v2] add netdev led trigger Andi Kleen
2010-12-01 0:03 ` Eric Cooper
2010-12-01 14:03 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201140330.GA7218@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).