From: "Stefan Lippers-Hollmann" <s.L-H@gmx.de>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Hayes Wang <hayeswang@realtek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH] net/r8169: Remove the firmware of RTL8111D
Date: Wed, 1 Dec 2010 17:36:55 +0100 [thread overview]
Message-ID: <201012011736.59625.s.L-H@gmx.de> (raw)
In-Reply-To: <20101201080732.GA3234@electric-eye.fr.zoreil.com>
Hi
On Wednesday 01 December 2010, Francois Romieu wrote:
> Hayes Wang <hayeswang@realtek.com> :
> > Remove the firmware of RTL8111D from the kernel.
> > The binary file of firmware would be moved to linux-firmware repository.
>
> The driver can not simply go along when request_firmware fails. Though Ben's
> code did not take care of it, the driver should imho propagate some return
> code. Ben ?
[...]
At least for RTL8111D-1 (rtl8168d_1_hw_phy_config(), phy_reg_init_2[])
a missing firmware update doesn't seem to be fatal
http://bugs.debian.org/561309#45
I'm running that card (onboard of the Intel D945GSEJT mainboard), with
rtl8168d_1_hw_phy_config()/ phy_reg_init_2[] stripped out, without any
noticable issues for about a year as always-on home server and good
GBit/s performance.
[ 3.861378] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[ 3.861462] r8169 0000:01:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
[ 3.861575] r8169 0000:01:00.0: setting latency timer to 64
[ 3.861703] r8169 0000:01:00.0: irq 45 for MSI/MSI-X
[ 3.865188] r8169 0000:01:00.0: eth0: RTL8168d/8111d at 0xf8406000, 00:1c:c0:ee:22:88, XID 081000c0 IRQ 45
using Debian's firmware removal patch and without the required firmware
image being present
[ 3.870663] eth0: unable to apply firmware patch
[ 16.364231] r8169 0000:01:00.0: eth0: link up
[ 26.562069] eth0: no IPv6 routers present
Debian has been shipping (unstable and a little later squeeze, the
upcoming stable) kernels with this firmware stripped out since late
december 2009.
Therefore I'd think it's safe to just make some noise about missing
firmware images and not cease operations completely for this chipset.
Regards
Stefan Lippers-Hollmann
next prev parent reply other threads:[~2010-12-01 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 5:22 [PATCH] net/r8169: Remove the firmware of RTL8111D Hayes Wang
2010-12-01 8:07 ` Francois Romieu
2010-12-01 9:54 ` hayeswang
2010-12-01 16:36 ` Stefan Lippers-Hollmann [this message]
2010-12-01 17:05 ` Ben Hutchings
2010-12-01 22:40 ` Francois Romieu
2010-12-06 4:38 ` Ben Hutchings
2010-12-06 22:04 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012011736.59625.s.L-H@gmx.de \
--to=s.l-h@gmx.de \
--cc=ben@decadent.org.uk \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).