From: Thomas Graf <tgraf@infradead.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [Patch] net: kill an RCU warning in inet_fill_link_af()
Date: Wed, 1 Dec 2010 17:22:33 -0500 [thread overview]
Message-ID: <20101201222233.GB22009@canuck.infradead.org> (raw)
In-Reply-To: <1291224717.2856.1021.camel@edumazet-laptop>
On Wed, Dec 01, 2010 at 06:31:57PM +0100, Eric Dumazet wrote:
> Are you sure RTNL is not held while dumping ?
>
> Patrick did the change to hold RTNL while dumping too, 3.5 years ago.
> Check commits 6313c1e0992fea, 1c2d670f3660e9103 ([RTNETLINK]: Hold
> rtnl_mutex during netlink dump callbacks)
You are right, I only looked at netlink_dump_start() where the lock
is released after setting ->cb. We grab RTNL again in netlink_dump()
after allocating the skb.
next prev parent reply other threads:[~2010-12-01 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 11:14 [Patch] net: kill an RCU warning in inet_fill_link_af() Amerigo Wang
2010-12-01 11:21 ` Eric Dumazet
2010-12-01 11:37 ` [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference() Eric Dumazet
2010-12-06 21:00 ` David Miller
2010-12-01 16:03 ` [Patch] net: kill an RCU warning in inet_fill_link_af() Eric Dumazet
2010-12-01 17:18 ` Thomas Graf
2010-12-01 17:31 ` Eric Dumazet
2010-12-01 22:22 ` Thomas Graf [this message]
2010-12-02 3:14 ` Cong Wang
2010-12-06 21:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201222233.GB22009@canuck.infradead.org \
--to=tgraf@infradead.org \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).