From: Greg KH <gregkh@suse.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Greg KH <greg@kroah.com>,
Ben Hutchings <bhutchings@solarflare.com>,
erazor_de@users.sourceforge.net,
Randy Dunlap <rdunlap@xenotime.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers
Date: Thu, 2 Dec 2010 07:16:42 -0800 [thread overview]
Message-ID: <20101202151642.GA15449@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1012021604110.14806@pobox.suse.cz>
On Thu, Dec 02, 2010 at 04:04:35PM +0100, Jiri Kosina wrote:
> On Tue, 30 Nov 2010, Greg KH wrote:
>
> > > > Using pack pragma to prevent padding bytes in binary data structures
> > > > used for hardware communication. Explanation of these pragmas was requested.
> > > [...]
> > >
> > > It would be clearer to use the '__packed' macro after each structure
> > > definition instead of using this awful Microsoft extension.
> >
> > I agree, that's the "normal" Linux way of doing things.
> >
> > Other than that, this patch set looks good to me. Jiri, if the packed
> > change is made, do you want me to take these through my tree, or do you
> > want to take them through yours? Whatever is easier for you is fine
> > with me.
>
> Hi Greg,
>
> as this is part of larger roccat patchset, I will be processing it through
> my tree once completely reviewed.
Great, feel free to add my:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to the driver core changes.
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-02 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1290801456.18750.164.camel@neuromancer>
2010-11-26 20:50 ` [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers Ben Hutchings
2010-11-30 17:40 ` Greg KH
2010-12-02 15:04 ` Jiri Kosina
2010-12-02 15:16 ` Greg KH [this message]
2010-11-26 19:57 Stefan Achatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202151642.GA15449@suse.de \
--to=gregkh@suse.de \
--cc=bhutchings@solarflare.com \
--cc=erazor_de@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).