From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] net: am79c961a: Omit private ndo_get_stats function Date: Fri, 3 Dec 2010 15:40:57 +0000 Message-ID: <20101203154057.GC30898@n2100.arm.linux.org.uk> References: <1291310405-5759-1-git-send-email-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org To: Tobias Klauser Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:45436 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168Ab0LCPlI (ORCPT ); Fri, 3 Dec 2010 10:41:08 -0500 Content-Disposition: inline In-Reply-To: <1291310405-5759-1-git-send-email-tklauser@distanz.ch> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Dec 02, 2010 at 06:20:05PM +0100, Tobias Klauser wrote: > am79c961_getstats() just returns dev->stats so we can leave it out > alltogether and let dev_get_stats() do the job. > > Signed-off-by: Tobias Klauser Acked-by: Russell King > --- > drivers/net/arm/am79c961a.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c > index 62f2110..0c9217f 100644 > --- a/drivers/net/arm/am79c961a.c > +++ b/drivers/net/arm/am79c961a.c > @@ -340,14 +340,6 @@ am79c961_close(struct net_device *dev) > return 0; > } > > -/* > - * Get the current statistics. > - */ > -static struct net_device_stats *am79c961_getstats (struct net_device *dev) > -{ > - return &dev->stats; > -} > - > static void am79c961_mc_hash(char *addr, unsigned short *hash) > { > if (addr[0] & 0x01) { > @@ -665,7 +657,6 @@ static const struct net_device_ops am79c961_netdev_ops = { > .ndo_open = am79c961_open, > .ndo_stop = am79c961_close, > .ndo_start_xmit = am79c961_sendpacket, > - .ndo_get_stats = am79c961_getstats, > .ndo_set_multicast_list = am79c961_setmulticastlist, > .ndo_tx_timeout = am79c961_timeout, > .ndo_validate_addr = eth_validate_addr, > -- > 1.7.0.4 >