From: David Miller <davem@davemloft.net>
To: leitao@linux.vnet.ibm.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: add the correct LRO status at dev->features
Date: Mon, 06 Dec 2010 09:33:12 -0800 (PST) [thread overview]
Message-ID: <20101206.093312.71114491.davem@davemloft.net> (raw)
In-Reply-To: <4CFD15F6.7040609@linux.vnet.ibm.com>
From: Breno Leitao <leitao@linux.vnet.ibm.com>
Date: Mon, 06 Dec 2010 14:57:26 -0200
> On 12/06/2010 02:48 PM, Stephen Hemminger wrote:
>> On Mon, 6 Dec 2010 14:39:42 -0200
>> leitao@linux.vnet.ibm.com wrote:
>>
>>> Currently ehea is not setting NETIF_F_LRO, and it is not providing
>>> a callback for get_flags on ethtool. This patch fixes it.
>>>
>>> Signed-off-by: Breno Leitao<leitao@linux.vnet.ibm.com>
>>
>> More importantly, ehea does not support set_flags to disable LRO.
> Correct, currently LRO is a module parameter. I have an item in my
> TODO list to implement set_flags, and thus, the LRO scheme.
>
> So, if you prefer I can send this patch with the future set_flags
> ones. But, for now, this patch allows the user to check when LRO is
> enabled. As it is today, it shows that LRO is disabled all the time.
>
> Anyway, you choose what is the best option.
Your options are: 1) send a set_flags patch now 2) rip LRO support
completely out of the ehea driver.
The feature is implemented improperly, and as such we have every right
to forcefully disable it or remove it until it is fixed to function
correctly.
prev parent reply other threads:[~2010-12-06 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 16:39 [PATCH] ehea: add the correct LRO status at dev->features leitao
2010-12-06 16:48 ` Stephen Hemminger
2010-12-06 16:57 ` Breno Leitao
2010-12-06 17:10 ` [RFC] mark devices with broken LRO implementation Stephen Hemminger
2010-12-06 17:18 ` Olof Johansson
2010-12-06 17:28 ` David Miller
2010-12-06 17:58 ` Stephen Hemminger
2010-12-06 17:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206.093312.71114491.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).