From: David Miller <davem@davemloft.net>
To: opurdila@ixiacom.com
Cc: netdev@vger.kernel.org, ddvlad@rosedu.org, lucian.grijincu@gmail.com
Subject: Re: [PATCH net-next-2.6] net: dummy: add auto_up module parameter
Date: Mon, 06 Dec 2010 12:36:46 -0800 (PST) [thread overview]
Message-ID: <20101206.123646.183042768.davem@davemloft.net> (raw)
In-Reply-To: <1291132647-15018-1-git-send-email-opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Tue, 30 Nov 2010 17:57:27 +0200
> Add auto_up module parameter to automatically bring up the created
> devices. This is useful when using the dummy driver for testing net
> device register / unregister performance.
>
> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
Registering a new netdevice with IFF_UP set is an error. You can't
set IFF_UP without also doing all of the other work, callbacks, and
state changes which are made by dev_open()'s code paths.
If, as you say, your interests are in testing register/unregister
performance, you can do that by making the appropriate calls in a loop
from userspace.
I honestly don't see what you hope to gain with this change, and
anyways since the registration state is basically illegal you'll need
to find another way to do this.
prev parent reply other threads:[~2010-12-06 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 15:57 [PATCH net-next-2.6] net: dummy: add auto_up module parameter Octavian Purdila
2010-12-06 20:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206.123646.183042768.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ddvlad@rosedu.org \
--cc=lucian.grijincu@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).