From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: amwang@redhat.com, linux-kernel@vger.kernel.org,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference()
Date: Mon, 06 Dec 2010 13:00:15 -0800 (PST) [thread overview]
Message-ID: <20101206.130015.246519364.davem@davemloft.net> (raw)
In-Reply-To: <1291203462.2856.607.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Dec 2010 12:37:42 +0100
> Le mercredi 01 décembre 2010 à 12:21 +0100, Eric Dumazet a écrit :
>
>> Same here. RTNL is held. Please use __in_dev_get_rtnl()
>
> By the way we can use rtnl_dereference() in __in_dev_get_rtnl()
>
> [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference()
>
> If caller holds RTNL, we dont need a memory barrier
> (smp_read_barrier_depends) included in rcu_dereference().
>
> Just use rtnl_dereference() to properly document the assertions.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
next prev parent reply other threads:[~2010-12-06 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 11:14 [Patch] net: kill an RCU warning in inet_fill_link_af() Amerigo Wang
2010-12-01 11:21 ` Eric Dumazet
2010-12-01 11:37 ` [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference() Eric Dumazet
2010-12-06 21:00 ` David Miller [this message]
2010-12-01 16:03 ` [Patch] net: kill an RCU warning in inet_fill_link_af() Eric Dumazet
2010-12-01 17:18 ` Thomas Graf
2010-12-01 17:31 ` Eric Dumazet
2010-12-01 22:22 ` Thomas Graf
2010-12-02 3:14 ` Cong Wang
2010-12-06 21:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206.130015.246519364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).